Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2801873007: Resume encryption migration immediately if the previous migration is incomplete. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Resume encryption migration immediately if the previous migration is incomplete. The previous migration can be incomplete. This can happen when, for example, the user shut down the device during the migration. In this case, MountEx returns a dedicated error: MOUNT_ERROR_PREVIOUS_MIGRATION_INCOMPLETE. If Chrome get this error, the migration should start immediately without asking the user's choice, as the user can not skip the migration. BUG=706017 TEST=manually tested by modifying fake_cryptohome_client to return the error. Review-Url: https://codereview.chromium.org/2801873007 Cr-Commit-Position: refs/heads/master@{#463151} Committed: https://chromium.googlesource.com/chromium/src/+/fbd1dfec1f46320180425e602cb2751978813ecb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -15 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/screens/encryption_migration_screen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/encryption_migration_screen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/encryption_migration_screen_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chromeos/login/auth/auth_status_consumer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/login/auth/auth_status_consumer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 2 chunks +4 lines, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 3 chunks +13 lines, -4 lines 0 comments Download
M chromeos/login/auth/login_performer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/login/auth/login_performer.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
fukino
Xiyuan, could you take a look?
3 years, 8 months ago (2017-04-07 11:54:12 UTC) #3
xiyuan
lgtm
3 years, 8 months ago (2017-04-07 15:12:17 UTC) #4
fukino
On 2017/04/07 15:12:17, xiyuan wrote: > lgtm Thank you!
3 years, 8 months ago (2017-04-09 08:45:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801873007/1
3 years, 8 months ago (2017-04-09 08:45:27 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-09 21:57:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fbd1dfec1f46320180425e602cb2...

Powered by Google App Engine
This is Rietveld 408576698