Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2801873005: Un-skipped wpt csp generic tests (Closed)

Created:
3 years, 8 months ago by andypaicu
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Un-skipped wpt csp generic tests Most tests were passing as they were Brought 2 tests into CSP3 land in regards to the violated directive BUG=694525 Review-Url: https://codereview.chromium.org/2801873005 Cr-Commit-Position: refs/heads/master@{#462820} Committed: https://chromium.googlesource.com/chromium/src/+/5a0135d881a3974cb6b1543c27d3ed6c11e7721e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/generic-0_1-img-src.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/generic/generic-0_1-script-src.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
andypaicu
3 years, 8 months ago (2017-04-07 08:07:18 UTC) #2
Mike West
LGTM. Can we remove any of our internal tests based upon these?
3 years, 8 months ago (2017-04-07 08:52:01 UTC) #5
andypaicu
On 2017/04/07 at 08:52:01, mkwst wrote: > LGTM. > > Can we remove any of ...
3 years, 8 months ago (2017-04-07 09:32:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801873005/1
3 years, 8 months ago (2017-04-07 09:33:08 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 09:37:40 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a0135d881a3974cb6b1543c27d3...

Powered by Google App Engine
This is Rietveld 408576698