Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2801823004: Revert of prerender: disable all browser tests on mac asan (Closed)

Created:
3 years, 8 months ago by findit-for-me
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of prerender: disable all browser tests on mac asan (patchset #1 id:1 of https://codereview.chromium.org/2798273003/ ) Reason for revert: Findit identified CL at revision 462525 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q5ZjJkYzIyMDMwY2Y4ZDQ2NWE2YzZlMzFkOTRiNTNiNTgxNDYzYzEM Original issue's description: > prerender: disable all browser tests on mac asan > > All of these tests seem flaky on mac asan. > > BUG=708158 > TBR=pasko@chromium.org > > Review-Url: https://codereview.chromium.org/2798273003 > Cr-Commit-Position: refs/heads/master@{#462525} > Committed: https://chromium.googlesource.com/chromium/src/+/d9f2dc22030cf8d465a6c6e31d94b53b581463c1 TBR=pasko@chromium.org,peter@chromium.org,ellyjones@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 4 chunks +35 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
findit-for-me
Created Revert of prerender: disable all browser tests on mac asan
3 years, 8 months ago (2017-04-06 18:15:30 UTC) #1
findit-for-me
Sheriffs: Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct. If ...
3 years, 8 months ago (2017-04-06 18:15:32 UTC) #3
Peter Beverloo
Fix is already on the CQ here: https://codereview.chromium.org/2803003003
3 years, 8 months ago (2017-04-06 18:16:42 UTC) #4
Peter Beverloo
3 years, 8 months ago (2017-04-06 18:17:03 UTC) #5
(To be clear, with NOTRY & NOTREECHECKS to make it happen fast it up.)

Powered by Google App Engine
This is Rietveld 408576698