Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Issue 2798273003: prerender: disable all browser tests on mac asan (Closed)

Created:
3 years, 8 months ago by Elly Fong-Jones
Modified:
3 years, 8 months ago
Reviewers:
pasko, Peter Beverloo
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

prerender: disable all browser tests on mac asan All of these tests seem flaky on mac asan. BUG=708158 TBR=pasko@chromium.org Review-Url: https://codereview.chromium.org/2798273003 Cr-Commit-Position: refs/heads/master@{#462525} Committed: https://chromium.googlesource.com/chromium/src/+/d9f2dc22030cf8d465a6c6e31d94b53b581463c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -35 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 4 chunks +9 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Elly Fong-Jones
3 years, 8 months ago (2017-04-06 16:16:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798273003/1
3 years, 8 months ago (2017-04-06 16:32:52 UTC) #5
Peter Beverloo
lgtm
3 years, 8 months ago (2017-04-06 16:34:59 UTC) #6
pasko
lgtm
3 years, 8 months ago (2017-04-06 16:43:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d9f2dc22030cf8d465a6c6e31d94b53b581463c1
3 years, 8 months ago (2017-04-06 17:22:14 UTC) #10
findit-for-me
3 years, 8 months ago (2017-04-06 18:15:30 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2801823004/ by
findit-for-me@appspot.gserviceaccount.com.

The reason for reverting is: 
Findit identified CL at revision 462525 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb....

Powered by Google App Engine
This is Rietveld 408576698