Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: content/browser/presentation/presentation_service_impl.cc

Issue 2801823003: [Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl… (Closed)
Patch Set: resolve code review comments from Derek Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/presentation/presentation_service_impl.cc
diff --git a/content/browser/presentation/presentation_service_impl.cc b/content/browser/presentation/presentation_service_impl.cc
index 4499ea229eb3dc85d2175641fe71fae11a2da986..2ecdd5829da1659957faec0fb3075ae34951119a 100644
--- a/content/browser/presentation/presentation_service_impl.cc
+++ b/content/browser/presentation/presentation_service_impl.cc
@@ -417,6 +417,12 @@ void PresentationServiceImpl::DidFinishNavigation(
if (navigation_handle->IsSameDocument())
return;
+ // If a frame is receiver frame and it navigates from blank to some url (e.g.
+ // https://www.google.com), we do not unregister the corresponding offscreen
+ // presentation.
+ if (receiver_delegate_)
mlamouri (slow - plz ping) 2017/04/10 12:50:28 How do we know the navigation came from blank here
zhaobin 2017/04/10 21:05:58 Code removed.
+ return;
+
// Reset if the frame actually navigated.
Reset();
}

Powered by Google App Engine
This is Rietveld 408576698