third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h - Issue 2801823003: [Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h

Issue 2801823003: [Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl… (Closed)

Patch Set: resolve code review comments from Derek Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/presentation/presentation_service_impl.cc ('K') | « content/renderer/presentation/presentation_dispatcher.cc ('k') | third_party/WebKit/Source/modules/presentation/NavigatorPresentation.cpp » ('j') | third_party/WebKit/Source/modules/presentation/NavigatorPresentation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h

diff --git a/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h b/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h

index f888fe5c3116d3c88c2518c27fc8aa57d043804c..56c46d0495b033b665f876801a3ba3b323dcfe08 100644

--- a/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h

+++ b/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h

@@ -6,20 +6,23 @@

#define NavigatorPresentation_h

#include "core/frame/Navigator.h"

+#include "modules/ModulesExport.h"

#include "platform/Supplementable.h"

#include "platform/heap/Handle.h"

namespace blink {

+class Document;

class Navigator;

class Presentation;

-class NavigatorPresentation final

+class MODULES_EXPORT NavigatorPresentation final

mlamouri (slow - plz ping) 2017/04/10 12:50:28 Maybe just add MODULES_EXPORT on the method that n

zhaobin 2017/04/10 21:05:59 Done.

: public GarbageCollected<NavigatorPresentation>,

public Supplement<Navigator> {

USING_GARBAGE_COLLECTED_MIXIN(NavigatorPresentation);

public:

+ static NavigatorPresentation* from(Document&);

static NavigatorPresentation& from(Navigator&);

static Presentation* presentation(Navigator&);