[Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl…

third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Index: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
index 0098a74c7df56d21f8ae5625965f14619200b80b..eb703839266efc141624e5d790af5977dc742dbb 100644
--- a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
+++ b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
@@ -59,6 +59,7 @@
 #include "modules/device_orientation/DeviceOrientationController.h"
 #include "modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h"
 #include "modules/gamepad/NavigatorGamepad.h"
+#include "modules/presentation/PresentationReceiver.h"
 #include "modules/remoteplayback/HTMLMediaElementRemotePlayback.h"
 #include "modules/remoteplayback/RemotePlayback.h"
 #include "modules/serviceworkers/NavigatorServiceWorker.h"
@@ -160,6 +161,10 @@ void LocalFrameClientImpl::dispatchDidClearWindowObjectInMainWorld() {
       if (RuntimeEnabledFeatures::webVREnabled() ||
           OriginTrials::webVREnabled(document->getExecutionContext()))
         NavigatorVR::from(*document);
+      if (RuntimeEnabledFeatures::presentationEnabled() &&
+          m_webFrame->frame()->settings()->getPresentationReceiver()) {
+        PresentationReceiver::from(*document);

[mlamouri (slow - plz ping), 2017/04/11 13:10:16]

nit: can you either add a comment explaining that you call this in order to
ensure the object is created or rename the method something else than from?
Because the method is only used in this context and it returns a
PresentationReceiver* which is never actually used which can sound very weird to
a reader, I would prefer a more explicit name but I will leave this up to you :)

[mark a. foltz, 2017/04/11 17:34:07]

I asked Bin to implement this to be consistent with the surrounding code (for
better or worse).  I agree that a comment would help explain the intent. 
Perhaps all of these from() methods should be renamed to createFor() or
allocateFor() to make the side effect more obvious.

[zhaobin, 2017/04/11 17:43:59]

Added a comment :)

Mark suggested naming the function as PresentationReceiver::from() to be
consistent with other APIs above.

https://codereview.chromium.org/2801823003/diff/100001/third_party/WebKit/Sou...

+      }
     }
   }
   // FIXME: when extensions go out of process, this whole concept stops working.