[Presentation API] Change connection to 'connected' if start a presentation with "https://www.googl…

third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 41 matching lines @@
 #include "core/origin_trials/OriginTrials.h"
 #include "core/page/Page.h"
 #include "core/page/WindowFeatures.h"
 #include "modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h"
 #include "modules/device_light/DeviceLightController.h"
 #include "modules/device_orientation/DeviceMotionController.h"
 #include "modules/device_orientation/DeviceOrientationAbsoluteController.h"
 #include "modules/device_orientation/DeviceOrientationController.h"
 #include "modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h"
 #include "modules/gamepad/NavigatorGamepad.h"
+#include "modules/presentation/PresentationReceiver.h"
 #include "modules/remoteplayback/HTMLMediaElementRemotePlayback.h"
 #include "modules/remoteplayback/RemotePlayback.h"
 #include "modules/serviceworkers/NavigatorServiceWorker.h"
 #include "modules/serviceworkers/ServiceWorkerLinkResource.h"
 #include "modules/storage/DOMWindowStorageController.h"
 #include "modules/vr/NavigatorVR.h"
 #include "platform/Histogram.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/exported/WrappedResourceRequest.h"
@@ skipping 81 matching lines @@
       DeviceOrientationController::from(*document);
       DeviceOrientationAbsoluteController::from(*document);
       if (RuntimeEnabledFeatures::deviceLightEnabled())
         DeviceLightController::from(*document);
       NavigatorGamepad::from(*document);
       NavigatorServiceWorker::from(*document);
       DOMWindowStorageController::from(*document);
       if (RuntimeEnabledFeatures::webVREnabled() ||
           OriginTrials::webVREnabled(document->getExecutionContext()))
         NavigatorVR::from(*document);
+      if (RuntimeEnabledFeatures::presentationEnabled() &&
+          m_webFrame->frame()->settings()->getPresentationReceiver()) {
+        PresentationReceiver::from(*document);

[mlamouri (slow - plz ping), 2017/04/11 13:10:16]

nit: can you either add a comment explaining that you call this in order to
ensure the object is created or rename the method something else than from?
Because the method is only used in this context and it returns a
PresentationReceiver* which is never actually used which can sound very weird to
a reader, I would prefer a more explicit name but I will leave this up to you :)

[mark a. foltz, 2017/04/11 17:34:07]

I asked Bin to implement this to be consistent with the surrounding code (for
better or worse).  I agree that a comment would help explain the intent. 
Perhaps all of these from() methods should be renamed to createFor() or
allocateFor() to make the side effect more obvious.

[zhaobin, 2017/04/11 17:43:59]

Added a comment :)

Mark suggested naming the function as PresentationReceiver::from() to be
consistent with other APIs above.

https://codereview.chromium.org/2801823003/diff/100001/third_party/WebKit/Sou...

+      }
     }
   }
   // FIXME: when extensions go out of process, this whole concept stops working.
   WebDevToolsFrontendImpl* devToolsFrontend =
       m_webFrame->top()->isWebLocalFrame()
           ? toWebLocalFrameImpl(m_webFrame->top())->devToolsFrontend()
           : nullptr;
   if (devToolsFrontend)
     devToolsFrontend->didClearWindowObject(m_webFrame);
 }
@@ skipping 857 matching lines @@
   if (m_webFrame->client())
     m_webFrame->client()->setHasReceivedUserGesture();
 }
 
 void LocalFrameClientImpl::abortClientNavigation() {
   if (m_webFrame->client())
     m_webFrame->client()->abortClientNavigation();
 }
 
 }  // namespace blink