third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html - Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)

Patch Set: aw Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl_browsertest.cc ('K') | « third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html ('k') | third_party/WebKit/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html b/third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

index 979567c439a00997a5675087c56071152abe65f0..190cbc40530ec06e8ecc91aed681f4474806d511 100644

--- a/third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

+++ b/third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

@@ -6,6 +6,13 @@

if (window.testRunner)

testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(true);

+// JavaScript onbeforeunload dialogs require a user gesture.

+if (window.eventSender) {

+ eventSender.mouseMoveTo(5, 5);

+ eventSender.mouseDown();

+ eventSender.mouseUp();

window.onload = function() {

window.location.href = "resources/does-not-exist.html";

setTimeout(finishJSTest, 0);