third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html - Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/before-unload-returnValue.html

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)

Patch Set: aw Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/frame_host/render_frame_host_impl_browsertest.cc ('K') | « third_party/WebKit/LayoutTests/fast/events/before-unload-reloads.html ('k') | third_party/WebKit/LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 <script>	5 <script>

6 if (window.testRunner)	6 if (window.testRunner)

7 testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(true);	7 testRunner.setShouldStayOnPageAfterHandlingBeforeUnload(true);

8	8

	9 // JavaScript onbeforeunload dialogs require a user gesture.

	10 if (window.eventSender) {

	11 eventSender.mouseMoveTo(5, 5);

	12 eventSender.mouseDown();

	13 eventSender.mouseUp();

	14 }

	15

9 window.onload = function() {	16 window.onload = function() {

10 window.location.href = "resources/does-not-exist.html";	17 window.location.href = "resources/does-not-exist.html";

11 setTimeout(finishJSTest, 0);	18 setTimeout(finishJSTest, 0);

12 }	19 }

13	20

14 var testEvent;	21 var testEvent;

15 window.onbeforeunload = function(event) {	22 window.onbeforeunload = function(event) {

16 testEvent = event;	23 testEvent = event;

17 shouldBe("testEvent.__proto__", "BeforeUnloadEvent.prototype");	24 shouldBe("testEvent.__proto__", "BeforeUnloadEvent.prototype");

18 shouldBeEqualToString("testEvent.returnValue", "");	25 shouldBeEqualToString("testEvent.returnValue", "");

19 event.returnValue = "This is beforeunload from the top level frame.";	26 event.returnValue = "This is beforeunload from the top level frame.";

20 shouldBeEqualToString("testEvent.returnValue", "This is beforeunload from th e top level frame.");	27 shouldBeEqualToString("testEvent.returnValue", "This is beforeunload from th e top level frame.");

21 }	28 }

22 </script>	29 </script>

23 </head>	30 </head>

24 <body>	31 <body>

25 <script>	32 <script>

26 description("Tests the returnValue attribute of the BeforeUnloadEvent.");	33 description("Tests the returnValue attribute of the BeforeUnloadEvent.");

27 self.jsTestIsAsync = true;	34 self.jsTestIsAsync = true;

28 </script>	35 </script>

29 </body>	36 </body>

30 </html>	37 </html>

31	38

OLD	NEW