content/browser/web_contents/web_contents_impl.h - Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)

Patch Set: test fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 0cf03b1565eae126fc28d641db2e7d8ed4388e1e..5a5ed54c01b33c6385053a943362287ea3b41053 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -879,6 +879,8 @@ class CONTENT_EXPORT WebContentsImpl

JavaScriptDialogsInMainAndSubframes);

FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,

IframeBeforeUnloadParentHang);

+ FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,

+ BeforeUnloadDialogRequiresGesture);

// So |find_request_manager_| can be accessed for testing.

friend class FindRequestManagerTest;