Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)
Patch Set: test fix Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 872 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
873 TwoSubframesCreatePopupsSimultaneously); 873 TwoSubframesCreatePopupsSimultaneously);
874 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 874 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
875 TwoSubframesCreatePopupMenuWidgetsSimultaneously); 875 TwoSubframesCreatePopupMenuWidgetsSimultaneously);
876 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest, 876 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
877 CrossSiteIframeAccessibility); 877 CrossSiteIframeAccessibility);
878 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 878 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
879 JavaScriptDialogsInMainAndSubframes); 879 JavaScriptDialogsInMainAndSubframes);
880 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 880 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
881 IframeBeforeUnloadParentHang); 881 IframeBeforeUnloadParentHang);
882 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
883 BeforeUnloadDialogRequiresGesture);
882 884
883 // So |find_request_manager_| can be accessed for testing. 885 // So |find_request_manager_| can be accessed for testing.
884 friend class FindRequestManagerTest; 886 friend class FindRequestManagerTest;
885 887
886 // TODO(brettw) TestWebContents shouldn't exist! 888 // TODO(brettw) TestWebContents shouldn't exist!
887 friend class TestWebContents; 889 friend class TestWebContents;
888 890
889 class DestructionObserver; 891 class DestructionObserver;
890 892
891 // Represents a WebContents node in a tree of WebContents structure. 893 // Represents a WebContents node in a tree of WebContents structure.
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1586 // Adds/removes a callback called on creation of each new WebContents. 1588 // Adds/removes a callback called on creation of each new WebContents.
1587 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1589 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1588 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1590 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1589 1591
1590 DISALLOW_COPY_AND_ASSIGN(FriendWrapper); 1592 DISALLOW_COPY_AND_ASSIGN(FriendWrapper);
1591 }; 1593 };
1592 1594
1593 } // namespace content 1595 } // namespace content
1594 1596
1595 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1597 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698