Only show a beforeunload dialog if a frame has had a user gesture since its load.

content/browser/frame_host/render_frame_host_impl_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/macros.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/common/frame_messages.h"
 #include "content/public/browser/javascript_dialog_manager.h"
@@ skipping 230 matching lines @@
   TestJavaScriptDialogManager dialog_manager;
   wc->SetDelegate(&dialog_manager);
 
   EXPECT_TRUE(NavigateToURL(shell(), GURL("about:blank")));
   // Make an iframe with a beforeunload handler.
   std::string script =
       "var iframe = document.createElement('iframe');"
       "document.body.appendChild(iframe);"
       "iframe.contentWindow.onbeforeunload=function(e){return 'x'};";
   EXPECT_TRUE(content::ExecuteScript(wc, script));
-  EXPECT_TRUE(WaitForLoadStop(shell()->web_contents()));
+  EXPECT_TRUE(WaitForLoadStop(wc));
+
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame : wc->GetAllFrames())
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
 
   // Force a process switch by going to a privileged page. The beforeunload
   // timer will be started on the top-level frame but will be paused while the
   // beforeunload dialog is shown by the subframe.
   GURL web_ui_page(std::string(kChromeUIScheme) + "://" +
                    std::string(kChromeUIGpuHost));
   shell()->LoadURL(web_ui_page);
   dialog_manager.Wait();
 
   RenderFrameHostImpl* main_frame =
@@ skipping 12 matching lines @@
   // There will be no beforeunload ACK, so if the beforeunload ACK timer isn't
   // functioning then the navigation will hang forever and this test will time
   // out. If this waiting for the load stop works, this test won't time out.
   EXPECT_TRUE(WaitForLoadStop(wc));
   EXPECT_EQ(web_ui_page, wc->GetLastCommittedURL());
 
   wc->SetDelegate(nullptr);
   wc->SetJavaScriptDialogManagerForTesting(nullptr);
 }
 
+// Tests that a gesture is required in a frame before it can request a
+// beforeunload dialog.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostImplBrowserTest,
+                       BeforeUnloadDialogRequiresGesture) {
+  WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell()->web_contents());
+  TestJavaScriptDialogManager dialog_manager;
+  wc->SetDelegate(&dialog_manager);
+
+  EXPECT_TRUE(NavigateToURL(
+      shell(), GetTestUrl("render_frame_host", "beforeunload.html")));
+  // Disable the hang monitor, otherwise there will be a race between the
+  // beforeunload dialog and the beforeunload hang timer.
+  wc->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();

[Nico, 2017/04/07 20:05:28]

Huh, I guess it makes sense here.

[Avi (use Gerrit), 2017/05/05 15:30:04]

Done.

+
+  // Reload. There should be no beforeunload dialog because there was no gesture
+  // on the page. If there was, this WaitForLoadStop call will hang.
+  wc->GetController().Reload(ReloadType::NORMAL, false);
+  EXPECT_TRUE(WaitForLoadStop(wc));
+
+  // Give the page a user gesture and try leaving again. This time there
+  // should be a dialog. If there is no dialog, the call to Wait will hang.
+  wc->GetMainFrame()->ExecuteJavaScriptWithUserGestureForTests(
+      base::string16());
+  shell()->LoadURL(GURL("about:blank"));
+  dialog_manager.Wait();
+
+  // Answer the dialog.
+  dialog_manager.callback().Run(false, base::string16());
+
+  wc->SetDelegate(nullptr);
+  wc->SetJavaScriptDialogManagerForTesting(nullptr);
+}
+
 }  // namespace content