Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: content/browser/web_contents/web_contents_impl.h

Issue 2801813005: Only show a beforeunload dialog if a frame has had a user gesture since its load. (Closed)
Patch Set: aw Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 5 #ifndef CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 6 #define CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <functional> 10 #include <functional>
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 870 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
871 TwoSubframesCreatePopupsSimultaneously); 871 TwoSubframesCreatePopupsSimultaneously);
872 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 872 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
873 TwoSubframesCreatePopupMenuWidgetsSimultaneously); 873 TwoSubframesCreatePopupMenuWidgetsSimultaneously);
874 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest, 874 FRIEND_TEST_ALL_PREFIXES(SitePerProcessAccessibilityBrowserTest,
875 CrossSiteIframeAccessibility); 875 CrossSiteIframeAccessibility);
876 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest, 876 FRIEND_TEST_ALL_PREFIXES(WebContentsImplBrowserTest,
877 JavaScriptDialogsInMainAndSubframes); 877 JavaScriptDialogsInMainAndSubframes);
878 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest, 878 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
879 IframeBeforeUnloadParentHang); 879 IframeBeforeUnloadParentHang);
880 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostImplBrowserTest,
881 BeforeUnloadDialogRequiresGesture);
880 882
881 // So |find_request_manager_| can be accessed for testing. 883 // So |find_request_manager_| can be accessed for testing.
882 friend class FindRequestManagerTest; 884 friend class FindRequestManagerTest;
883 885
884 // TODO(brettw) TestWebContents shouldn't exist! 886 // TODO(brettw) TestWebContents shouldn't exist!
885 friend class TestWebContents; 887 friend class TestWebContents;
886 888
887 class DestructionObserver; 889 class DestructionObserver;
888 890
889 // Represents a WebContents node in a tree of WebContents structure. 891 // Represents a WebContents node in a tree of WebContents structure.
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
1592 // Adds/removes a callback called on creation of each new WebContents. 1594 // Adds/removes a callback called on creation of each new WebContents.
1593 static void AddCreatedCallbackForTesting(const CreatedCallback& callback); 1595 static void AddCreatedCallbackForTesting(const CreatedCallback& callback);
1594 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback); 1596 static void RemoveCreatedCallbackForTesting(const CreatedCallback& callback);
1595 1597
1596 DISALLOW_COPY_AND_ASSIGN(FriendWrapper); 1598 DISALLOW_COPY_AND_ASSIGN(FriendWrapper);
1597 }; 1599 };
1598 1600
1599 } // namespace content 1601 } // namespace content
1600 1602
1601 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_ 1603 #endif // CONTENT_BROWSER_WEB_CONTENTS_WEB_CONTENTS_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698