Only show a beforeunload dialog if a frame has had a user gesture since its load.

chrome/browser/ui/browser_browsertest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 606 matching lines @@
 IN_PROC_BROWSER_TEST_F(BrowserTest, SadTabCancelsDialogs) {
   ASSERT_TRUE(embedded_test_server()->Start());
   host_resolver()->AddRule("www.example.com", "127.0.0.1");
   GURL beforeunload_url(embedded_test_server()->GetURL("/beforeunload.html"));
   ui_test_utils::NavigateToURL(browser(), beforeunload_url);
   WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
   // Disable the hang monitor, otherwise there will be a race between the
   // beforeunload dialog and the beforeunload hang timer.
   contents->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();
 
+  // JavaScript onbeforeunload dialogs require a user gesture.

[Nico, 2017/04/07 20:05:28]

You're adding this exactly in the tests where you added
DisableBeforeUnloadHangMonitorForTesting(), right? Maybe there can at least be a
helper that does DisableBeforeUnloadHangMonitorForTesting() and this loop? Does
it ever make sense to have only one of
DisableBeforeUnloadHangMonitorForTesting() and loop?

[Charlie Reis, 2017/04/10 06:20:11]

It does seem like the majority of cases would benefit from a helper that does
both.

[Avi (use Gerrit), 2017/05/05 15:30:04]

Done.

+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Start a navigation to trigger the beforeunload dialog.
   contents->GetMainFrame()->ExecuteJavaScriptForTests(
       ASCIIToUTF16("window.location.href = 'about:blank'"));
   AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
   EXPECT_TRUE(alert->IsValid());
   AppModalDialogQueue* dialog_queue = AppModalDialogQueue::GetInstance();
   EXPECT_TRUE(dialog_queue->HasActiveDialog());
 
   // Crash the renderer process and ensure the dialog is gone.
   content::RenderProcessHost* child_process = contents->GetRenderProcessHost();
@@ skipping 69 matching lines @@
 // Test for crbug.com/22004.  Reloading a page with a before unload handler and
 // then canceling the dialog should not leave the throbber spinning.
 IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) {
   GURL url(std::string("data:text/html,") + kBeforeUnloadHTML);
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
   // Disable the hang monitor, otherwise there will be a race between the
   // beforeunload dialog and the beforeunload hang timer.
   contents->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();
 
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Navigate to another page, but click cancel in the dialog.  Make sure that
   // the throbber stops spinning.
   chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);
   AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
 
   FailedCommitWatcher watcher(contents);
   alert->CloseModalDialog();
   if (content::IsBrowserSideNavigationEnabled())
     watcher.Wait();
   EXPECT_FALSE(contents->IsLoading());
@@ skipping 104 matching lines @@
       SetBrowserClientForTesting(&new_client);
 
   // Navigate to a page with a beforeunload handler.
   GURL url(embedded_test_server()->GetURL("/beforeunload.html"));
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
   // Disable the hang monitor, otherwise there will be a race between the
   // beforeunload dialog and the beforeunload hang timer.
   contents->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();
 
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Navigate to a URL that redirects to another process and approve the
   // beforeunload dialog that pops up.
   content::WindowedNotificationObserver nav_observer(
       content::NOTIFICATION_NAV_ENTRY_COMMITTED,
       content::NotificationService::AllSources());
   GURL https_url(https_test_server.GetURL("/title1.html"));
   GURL redirect_url(
       embedded_test_server()->GetURL("/server-redirect?" + https_url.spec()));
   browser()->OpenURL(OpenURLParams(redirect_url, Referrer(),
                                    WindowOpenDisposition::CURRENT_TAB,
@@ skipping 12 matching lines @@
 // the URL to the previous page's URL.
 IN_PROC_BROWSER_TEST_F(BrowserTest, CancelBeforeUnloadResetsURL) {
   GURL url(ui_test_utils::GetTestUrl(base::FilePath(
       base::FilePath::kCurrentDirectory), base::FilePath(kBeforeUnloadFile)));
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
   // Disable the hang monitor, otherwise there will be a race between the
   // beforeunload dialog and the beforeunload hang timer.
   contents->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();
 
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Navigate to a page that triggers a cross-site transition.
   ASSERT_TRUE(embedded_test_server()->Start());
   GURL url2(embedded_test_server()->GetURL("/title1.html"));
   browser()->OpenURL(OpenURLParams(url2, Referrer(),
                                    WindowOpenDisposition::CURRENT_TAB,
                                    ui::PAGE_TRANSITION_TYPED, false));
 
   content::WindowedNotificationObserver host_destroyed_observer(
       content::NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED,
       content::NotificationService::AllSources());
@@ skipping 54 matching lines @@
 // Test that when a page has an onbeforeunload handler, reloading a page shows a
 // different dialog than navigating to a different page.
 IN_PROC_BROWSER_TEST_F(BrowserTest, BeforeUnloadVsBeforeReload) {
   GURL url(std::string("data:text/html,") + kBeforeUnloadHTML);
   ui_test_utils::NavigateToURL(browser(), url);
   WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();
   // Disable the hang monitor, otherwise there will be a race between the
   // beforeunload dialog and the beforeunload hang timer.
   contents->GetMainFrame()->DisableBeforeUnloadHangMonitorForTesting();
 
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Reload the page, and check that we get a "before reload" dialog.
   chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);
   AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();
   EXPECT_TRUE(static_cast<JavaScriptAppModalDialog*>(alert)->is_reload());
 
   // Cancel the reload.
   FailedCommitWatcher watcher(contents);
   alert->native_dialog()->CancelAppModalDialog();
   if (content::IsBrowserSideNavigationEnabled())
     watcher.Wait();
@@ skipping 50 matching lines @@
   }
 };
 
 // Disabled, http://crbug.com/159214 .
 IN_PROC_BROWSER_TEST_F(BeforeUnloadAtQuitWithTwoWindows,
                        DISABLED_IfThisTestTimesOutItIndicatesFAILURE) {
   // In the first browser, set up a page that has a beforeunload handler.
   GURL url(std::string("data:text/html,") + kBeforeUnloadHTML);
   ui_test_utils::NavigateToURL(browser(), url);
 
+  // JavaScript onbeforeunload dialogs require a user gesture.
+  for (auto* frame :
+       browser()->tab_strip_model()->GetActiveWebContents()->GetAllFrames()) {
+    frame->ExecuteJavaScriptWithUserGestureForTests(base::string16());
+  }
+
   // Open a second browser window at about:blank.
   ui_test_utils::BrowserAddedObserver browser_added_observer;
   chrome::NewEmptyWindow(browser()->profile());
   Browser* second_window = browser_added_observer.WaitForSingleNewBrowser();
   ui_test_utils::NavigateToURL(second_window, GURL(url::kAboutBlankURL));
 
   // Tell the application to quit. IDC_EXIT calls AttemptUserExit, which on
   // everything but ChromeOS allows unload handlers to block exit. On that
   // platform, though, it exits unconditionally. See the comment and bug ID
   // in AttemptUserExit() in application_lifetime.cc.
@@ skipping 1848 matching lines @@
     Browser* browser = new Browser(params);
     gfx::Rect bounds = browser->window()->GetBounds();
 
     // Should be EXPECT_EQ, but this width is inconsistent across platforms.
     // See https://crbug.com/567925.
     EXPECT_GE(bounds.width(), 100);
     EXPECT_EQ(122, bounds.height());
     browser->window()->Close();
   }
 }