Android: enable H264&VP8 HW accelerator for MediaRecorder

content/renderer/media_recorder/video_track_recorder.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RECORDER_VIDEO_TRACK_RECORDER_H_
 #define CONTENT_RENDERER_MEDIA_RECORDER_VIDEO_TRACK_RECORDER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 14 matching lines @@
 namespace cc {
 class PaintCanvas;
 }  // namespace cc
 
 namespace media {
 class SkCanvasVideoRenderer;
 class VideoFrame;
 }  // namespace media
 
 namespace video_track_recorder {
+#if !defined(OS_ANDROID)

[mcasas, 2017/04/17 20:10:39]

Don't use negative conditionals:

#if defined(OS_ANDROID)
// blabla
#else
// foo foo
#endif

[braveyao, 2017/04/18 16:15:38]

Done.

 const int kVEAEncoderMinResolutionWidth = 640;
 const int kVEAEncoderMinResolutionHeight = 480;
+#else
+// The minimum resolution supported by HW H264 on Android varies on each
+// platform and OS version.
+// Take Nexus 5 as an example, it's:
+// 176x144 on KitKat; 160x120 on Lollipop; 96x64 on Marshmallow and above.
+// Set 176x144 for now and revise it as the target API level changes.

[mcasas, 2017/04/17 20:10:39]

If there's an action for the future, we need a bug
and the usual line TODO(developer):... https://crbug.com/xyzuvw

Also, you say here: 176x144 but the value in l.44-45 is
172x144.

My suggestion here is to make it a conservative estimate, remove
all these superfluous data from the comment, and make the 
minimum dimensions QVGA: 320x240.

[braveyao, 2017/04/18 16:15:38]

Done.
Keeping minimum resolution to QCIF: 176x144

+const int kVEAEncoderMinResolutionWidth = 172;
+const int kVEAEncoderMinResolutionHeight = 144;
+#endif
 }  // namespace video_track_recorder
 
 namespace content {
 
 // VideoTrackRecorder is a MediaStreamVideoSink that encodes the video frames
 // received from a Stream Video Track. This class is constructed and used on a
 // single thread, namely the main Render thread. This mirrors the other
 // MediaStreamVideo* classes that are constructed/configured on Main Render
 // thread but that pass frames on Render IO thread. It has an internal Encoder
 // with its own threading subtleties, see the implementation file.
 class CONTENT_EXPORT VideoTrackRecorder
     : NON_EXPORTED_BASE(public MediaStreamVideoSink) {
  public:
   // Do not change the order of codecs; add new ones right before LAST.
   enum class CodecId {
     VP8,
     VP9,
-#if BUILDFLAG(RTC_USE_H264)
+#if BUILDFLAG(RTC_USE_H264) || defined(OS_ANDROID)
     H264,
 #endif
     LAST
   };
 
   using OnEncodedVideoCB =
       base::Callback<void(const media::WebmMuxer::VideoParameters& params,
                           std::unique_ptr<std::string> encoded_data,
                           std::unique_ptr<std::string> encoded_alpha,
                           base::TimeTicks capture_timestamp,
@@ skipping 124 matching lines @@
   // Used to track the paused state during the initialization process.
   bool paused_before_init_;
 
   base::WeakPtrFactory<VideoTrackRecorder> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoTrackRecorder);
 };
 
 }  // namespace content
 #endif  // CONTENT_RENDERER_MEDIA_RECORDER_VIDEO_TRACK_RECORDER_H_