Android: enable H264&VP8 HW accelerator for MediaRecorder

content/renderer/media_recorder/video_track_recorder_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media_recorder/video_track_recorder.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 29 matching lines @@
 namespace content {
 
 ACTION_P(RunClosure, closure) {
   closure.Run();
 }
 
 const VideoTrackRecorder::CodecId kTrackRecorderTestCodec[] = {
     VideoTrackRecorder::CodecId::VP8,
     VideoTrackRecorder::CodecId::VP9
 #if BUILDFLAG(RTC_USE_H264)
+    // This unittest can't enumerate HW codecs due to no render thread created.
+    // So H264 can't be included on Android because OpenH264 is not supported.

[emircan, 2017/04/17 17:24:06]

We create a ChildProcess for test on l.134 which should act like render thread
here for testing. What is the exact error you get here?

[braveyao, 2017/04/17 18:09:27]

It fails to enumerate VEA at
https://cs.chromium.org/chromium/src/content/renderer/media_recorder/video_tr....

I found the |child_process_| in this file,
https://cs.chromium.org/chromium/src/content/renderer/media_recorder/video_tr....
But it seems no one used it.

Anything else we can do?

[emircan, 2017/04/17 18:39:59]

I see. This test only exercises the SW encode path then, which doesn't exist on
Android for H264. 

     , VideoTrackRecorder::CodecId::H264
 #endif
 };
 const gfx::Size kTrackRecorderTestSize[] = {
+#if !defined(OS_ANDROID)

[mcasas, 2017/04/17 20:10:39]

Use positive ifdefs.

[braveyao, 2017/04/18 16:15:38]

Done.

     gfx::Size(kVEAEncoderMinResolutionWidth / 2,
               kVEAEncoderMinResolutionHeight / 2),

[mcasas, 2017/04/17 20:10:39]

Why do you do this? I think it's so that you can force 
the Sw encoder to be used. But that's not detailed 
anywhere, which will puzzle and confuse future 
developers. Find another way that is more maintainable.

[braveyao, 2017/04/18 16:15:38]

Done.
You're right. Forgot to remove it as H264 is excluded lately.

+#endif
     gfx::Size(kVEAEncoderMinResolutionWidth, kVEAEncoderMinResolutionHeight)};
 static const int kTrackRecorderTestSizeDiff = 20;
 
 class VideoTrackRecorderTest
     : public TestWithParam<
           testing::tuple<VideoTrackRecorder::CodecId, gfx::Size, bool>> {
  public:
   VideoTrackRecorderTest()
       : mock_source_(new MockMediaStreamVideoSource(false)) {
     const blink::WebString webkit_track_id(
@@ skipping 258 matching lines @@
   Mock::VerifyAndClearExpectations(this);
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         VideoTrackRecorderTest,
                         ::testing::Combine(ValuesIn(kTrackRecorderTestCodec),
                                            ValuesIn(kTrackRecorderTestSize),
                                            ::testing::Bool()));
 
 }  // namespace content