Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2801783002: Revert of Update robust read pixels to output number of columns and rows written. (Closed)

Created:
3 years, 8 months ago by hans
Modified:
3 years, 8 months ago
Reviewers:
Geoff Lang, piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update robust read pixels to output number of columns and rows written. (patchset #4 id:60001 of https://codereview.chromium.org/2787123002/ ) Reason for revert: This broke the 32-bit Windows Clang build. See https://crbug.com/708591 There's a patch for Angle to fix it, so hopefully we can re-roll soon again. Unfortunately the breakage wasn't caught by trybots as the Win-Clang bot only does 64-bit builds. Original issue's description: > Update robust read pixels to output number of columns and rows written. > > Allows the command buffer client to unpack the pixels without any code > changes when it knows which rows and columns were written to. > > Roll ANGLE fe48632..e93daba > https://chromium.googlesource.com/angle/angle.git/+log/fe48632..e93daba > BUG=angleproject:1354 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2787123002 > Cr-Commit-Position: refs/heads/master@{#461827} > Committed: https://chromium.googlesource.com/chromium/src/+/2751d5c8a72269724b6d3742a4619efe085bfc82 TBR=piman@chromium.org,geofflang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=angleproject:1354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -99 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doer_prototypes.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc View 1 chunk +1 line, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ui/gl/generate_bindings.py View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/gl/gl_bindings_api_autogen_gl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.h View 4 chunks +0 lines, -8 lines 0 comments Download
M ui/gl/gl_bindings_autogen_gl.cc View 8 chunks +6 lines, -26 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/gl/gl_bindings_autogen_mock.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gl/gl_mock.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ui/gl/gl_mock_autogen_gl.h View 2 chunks +20 lines, -4 lines 0 comments Download
M ui/gl/gl_stub_autogen_gl.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hans
Created Revert of Update robust read pixels to output number of columns and rows written.
3 years, 8 months ago (2017-04-05 16:57:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801783002/1
3 years, 8 months ago (2017-04-05 16:57:48 UTC) #3
Geoff Lang
This has already been fixed in ANGLE and rolled into Chrome, please reach out before ...
3 years, 8 months ago (2017-04-05 16:58:24 UTC) #5
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-05 16:58:41 UTC) #7
hans
3 years, 8 months ago (2017-04-05 17:00:56 UTC) #8
On 2017/04/05 16:58:24, Geoff Lang wrote:
> This has already been fixed in ANGLE and rolled into Chrome, please reach out
> before reverting.

Excellent! Thanks.

Powered by Google App Engine
This is Rietveld 408576698