Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2801763002: [inspector] fixed injected-script-host crash (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed injected-script-host crash It's possible to get undefined as a result of Object.getOwnPropertyDescriptor. We should be ready for this. BUG=chromium:707670 R=alph@chromium.org Review-Url: https://codereview.chromium.org/2801763002 Cr-Commit-Position: refs/heads/master@{#44532} Committed: https://chromium.googlesource.com/v8/v8/+/2e5dd217dfc3221f05a6186c1223947e300e8a8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/inspector/injected-script-source.js View 1 chunk +3 lines, -1 line 0 comments Download
M src/inspector/v8-injected-script-host.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kozy
Aleksey, please take a look.
3 years, 8 months ago (2017-04-05 15:11:49 UTC) #1
kozy
ping
3 years, 8 months ago (2017-04-10 02:44:39 UTC) #2
alph
lgtm
3 years, 8 months ago (2017-04-10 08:15:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801763002/1
3 years, 8 months ago (2017-04-10 15:16:06 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 15:44:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2e5dd217dfc3221f05a6186c1223947e300...

Powered by Google App Engine
This is Rietveld 408576698