Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 2801743003: v8binding: Fixes a comment about the Incumbent realm in Bluetooth. (Closed)

Created:
3 years, 8 months ago by Yuki
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

v8binding: Fixes a comment about the Incumbent realm in Bluetooth. Simply fixes a comment in Bluetooth::requestDevice, which says that it's "Incumbent", but actually it's "Relevant". BUG= Review-Url: https://codereview.chromium.org/2801743003 Cr-Commit-Position: refs/heads/master@{#462806} Committed: https://chromium.googlesource.com/chromium/src/+/3bbe38dc9aa2ff4b3cdccf3ef4c46af587d2a8d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Yuki
Could you review this CL? This is just confusing.
3 years, 8 months ago (2017-04-06 13:11:33 UTC) #4
haraken
LGTM
3 years, 8 months ago (2017-04-06 16:24:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801743003/1
3 years, 8 months ago (2017-04-07 08:12:23 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 08:17:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bbe38dc9aa2ff4b3cdccf3ef4c4...

Powered by Google App Engine
This is Rietveld 408576698