Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2801733004: Fix comments in GN standalone docs. (Closed)

Created:
3 years, 8 months ago by Dirk Pranke
Modified:
3 years, 8 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix comments in GN standalone docs. The GN standalone docs appear to have had from day one a placeholder for a section that was never written. This CL deletes that placeholder and tweaks the wording above it to hopefully make a bit more sense. R=thakis@chromium.org, brettw@chromium.org Review-Url: https://codereview.chromium.org/2801733004 Cr-Commit-Position: refs/heads/master@{#462604} Committed: https://chromium.googlesource.com/chromium/src/+/707f1a623b690a870f6378ccf074b51cdaad9556

Patch Set 1 #

Patch Set 2 : add note about a completely standalone build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/gn/docs/standalone.md View 1 1 chunk +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
Dirk Pranke
3 years, 8 months ago (2017-04-06 02:31:57 UTC) #1
Nico
Lgtm, thanks! I think having a sentence about completely standalone builds that don't deps in ...
3 years, 8 months ago (2017-04-06 02:35:33 UTC) #2
Dirk Pranke
On 2017/04/06 02:35:33, Nico wrote: > Lgtm, thanks! > > I think having a sentence ...
3 years, 8 months ago (2017-04-06 02:57:07 UTC) #3
Nico
lgtm++
3 years, 8 months ago (2017-04-06 13:48:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801733004/20001
3 years, 8 months ago (2017-04-06 19:49:37 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 20:28:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/707f1a623b690a870f6378ccf074...

Powered by Google App Engine
This is Rietveld 408576698