Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2801733003: Put CanvasRenderingContext2D#getContextAttributes behind flag (Closed)

Created:
3 years, 8 months ago by zakerinasab
Modified:
3 years, 8 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, Rik, chromium-reviews, dshwang, haraken
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Put CanvasRenderingContext2D#getContextAttributes behind flag CanvasRenderingContext2D#getContextAttributes was unintentionally exposed in Chrome back in 2013, while it should have been behind ExperimentalCanvasFeatures flag. This CL puts the method behind a flag. This is safe as according to GetCanvas2DContextAttributes usage histogram no one is using it at this time. BUG=696005 Review-Url: https://codereview.chromium.org/2801733003 Cr-Commit-Position: refs/heads/master@{#466387} Committed: https://chromium.googlesource.com/chromium/src/+/47093fe643aa8f6a14a8800f73a4939e4be5a69f

Patch Set 1 : Putting the method behind flag #

Patch Set 2 : Rebaselining layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (18 generated)
Justin Novosad
Looke like more instances of global-interface-listing need to be rebaselined. Otherwise, lgtm
3 years, 8 months ago (2017-04-10 22:14:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801733003/100001
3 years, 8 months ago (2017-04-15 20:43:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/412229)
3 years, 8 months ago (2017-04-15 20:53:03 UTC) #12
chrishtr
lgtm
3 years, 8 months ago (2017-04-20 21:40:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801733003/100001
3 years, 8 months ago (2017-04-20 21:42:16 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/435883)
3 years, 8 months ago (2017-04-20 22:58:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801733003/100001
3 years, 8 months ago (2017-04-21 16:33:50 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 18:04:50 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/47093fe643aa8f6a14a8800f73a4...

Powered by Google App Engine
This is Rietveld 408576698