[DevTools] Do not reset storage tree items

third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js

 /*
  * Copyright (C) 2007, 2008, 2010 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  * Copyright (C) 2013 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 199 matching lines @@
           treeElement.revealAndSelect(true);
           return;
         }
       }
     }
     this._manifestTreeElement.select();
   }
 
   _resetWithFrames() {
     this._resourcesSection.reset();
-    this._reset();
+    this._resetCookies();

[dgozman, 2017/04/06 00:12:23]

No more _resetWebSQL?

[eostroukhov, 2017/04/06 00:26:18]

Done. Thanks for catching this!

   }
 
   _resetWebSQL() {
     var queryViews = this._databaseQueryViews.valuesArray();
     for (var i = 0; i < queryViews.length; ++i) {
       queryViews[i].removeEventListener(
           Resources.DatabaseQueryView.Events.SchemaUpdated, this._updateDatabaseTables, this);
     }
     this._databaseTableViews.clear();
     this._databaseQueryViews.clear();
     this._databaseTreeElements.clear();
     this.databasesListTreeElement.removeChildren();
     this.databasesListTreeElement.setExpandable(false);
   }
 
-  _resetDOMStorage() {
-    this._domStorageTreeElements.clear();
-    this.localStorageListTreeElement.removeChildren();
-    this.sessionStorageListTreeElement.removeChildren();
-  }
-
   _resetCookies() {
+    this._domains = {};
     this.cookieListTreeElement.removeChildren();
   }
 
-  _resetCacheStorage() {
-    this.cacheStorageListTreeElement.removeChildren();
-    this.cacheStorageListTreeElement.setExpandable(false);
-  }
-
   _resetAppCache() {
     for (var frameId of Object.keys(this._applicationCacheFrameElements))
       this._applicationCacheFrameManifestRemoved({data: frameId});
     this.applicationCacheListTreeElement.setExpandable(false);
   }
 
-  _reset() {
-    this._domains = {};
-    this._resetWebSQL();
-    this._resetDOMStorage();
-    this._resetCookies();
-    this._resetCacheStorage();
-    // No need to this._resetAppCache.
-
-    this._panel.resetView();
-
-    if (this._sidebarTree.selectedTreeElement)
-      this._sidebarTree.selectedTreeElement.deselect();
-  }
-
   _frameNavigated(event) {
     var frame = event.data;
 
     if (!frame.parentFrame)
-      this._reset();
+      this._resetCookies();

[dgozman, 2017/04/06 00:12:23]

No more _resetWebSQL?

[eostroukhov, 2017/04/06 00:26:18]

Done.

 
     var applicationCacheFrameTreeElement = this._applicationCacheFrameElements[frame.id];
     if (applicationCacheFrameTreeElement)
       applicationCacheFrameTreeElement.frameNavigated(frame);
     this._addCookieDocument(frame);
   }
 
   /**
    * @param {!Common.Event} event
    */
@@ skipping 566 matching lines @@
     var cache = /** @type {!SDK.ServiceWorkerCacheModel.Cache} */ (event.data.cache);
     var model = /** @type {!SDK.ServiceWorkerCacheModel} */ (event.data.model);
 
     var swCacheTreeElement = this._cacheTreeElement(model, cache);
     if (!swCacheTreeElement)
       return;
 
     swCacheTreeElement.clear();
     this.removeChild(swCacheTreeElement);
     this._swCacheTreeElements.remove(swCacheTreeElement);
+    this.setExpandable(this.childCount() > 0);
   }
 
   /**
    * @param {!SDK.ServiceWorkerCacheModel} model
    * @param {!SDK.ServiceWorkerCacheModel.Cache} cache
    * @return {?Resources.SWCacheTreeElement}
    */
   _cacheTreeElement(model, cache) {
     var index = -1;
     for (var i = 0; i < this._swCacheTreeElements.length; ++i) {
@@ skipping 251 matching lines @@
     var databaseId = /** @type {!Resources.IndexedDBModel.DatabaseId} */ (event.data.databaseId);
     var model = /** @type {!Resources.IndexedDBModel} */ (event.data.model);
 
     var idbDatabaseTreeElement = this._idbDatabaseTreeElement(model, databaseId);
     if (!idbDatabaseTreeElement)
       return;
 
     idbDatabaseTreeElement.clear();
     this.removeChild(idbDatabaseTreeElement);
     this._idbDatabaseTreeElements.remove(idbDatabaseTreeElement);
+    this.setExpandable(this.childCount() > 0);
   }
 
   /**
    * @param {!Common.Event} event
    */
   _indexedDBLoaded(event) {
     var database = /** @type {!Resources.IndexedDBModel.Database} */ (event.data.database);
     var model = /** @type {!Resources.IndexedDBModel} */ (event.data.model);
 
     var idbDatabaseTreeElement = this._idbDatabaseTreeElement(model, database.databaseId);
@@ skipping 504 matching lines @@
 
     this.element.classList.add('storage-view');
     this._emptyWidget = new UI.EmptyWidget('');
     this._emptyWidget.show(this.element);
   }
 
   setText(text) {
     this._emptyWidget.text = text;
   }
 };