Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js

Issue 2801723003: [DevTools] Do not reset storage tree items (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
index 2c738b0a25d95bfe12ef4fef0148dafb8aa51d7d..7dd64bcd95febfb69111ebbb2e14c0b6803a5e1f 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
@@ -217,7 +217,7 @@ Resources.ApplicationPanelSidebar = class extends UI.VBox {
_resetWithFrames() {
this._resourcesSection.reset();
- this._reset();
+ this._resetCookies();
dgozman 2017/04/06 00:12:23 No more _resetWebSQL?
eostroukhov 2017/04/06 00:26:18 Done. Thanks for catching this!
}
_resetWebSQL() {
@@ -233,46 +233,22 @@ Resources.ApplicationPanelSidebar = class extends UI.VBox {
this.databasesListTreeElement.setExpandable(false);
}
- _resetDOMStorage() {
- this._domStorageTreeElements.clear();
- this.localStorageListTreeElement.removeChildren();
- this.sessionStorageListTreeElement.removeChildren();
- }
-
_resetCookies() {
+ this._domains = {};
this.cookieListTreeElement.removeChildren();
}
- _resetCacheStorage() {
- this.cacheStorageListTreeElement.removeChildren();
- this.cacheStorageListTreeElement.setExpandable(false);
- }
-
_resetAppCache() {
for (var frameId of Object.keys(this._applicationCacheFrameElements))
this._applicationCacheFrameManifestRemoved({data: frameId});
this.applicationCacheListTreeElement.setExpandable(false);
}
- _reset() {
- this._domains = {};
- this._resetWebSQL();
- this._resetDOMStorage();
- this._resetCookies();
- this._resetCacheStorage();
- // No need to this._resetAppCache.
-
- this._panel.resetView();
-
- if (this._sidebarTree.selectedTreeElement)
- this._sidebarTree.selectedTreeElement.deselect();
- }
-
_frameNavigated(event) {
var frame = event.data;
if (!frame.parentFrame)
- this._reset();
+ this._resetCookies();
dgozman 2017/04/06 00:12:23 No more _resetWebSQL?
eostroukhov 2017/04/06 00:26:18 Done.
var applicationCacheFrameTreeElement = this._applicationCacheFrameElements[frame.id];
if (applicationCacheFrameTreeElement)
@@ -859,6 +835,7 @@ Resources.ServiceWorkerCacheTreeElement = class extends Resources.StorageCategor
swCacheTreeElement.clear();
this.removeChild(swCacheTreeElement);
this._swCacheTreeElements.remove(swCacheTreeElement);
+ this.setExpandable(this.childCount() > 0);
}
/**
@@ -1130,6 +1107,7 @@ Resources.IndexedDBTreeElement = class extends Resources.StorageCategoryTreeElem
idbDatabaseTreeElement.clear();
this.removeChild(idbDatabaseTreeElement);
this._idbDatabaseTreeElements.remove(idbDatabaseTreeElement);
+ this.setExpandable(this.childCount() > 0);
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698