Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2801693002: Add MobileMenuDataSaverOpened to actions.xml. (Closed)

Created:
3 years, 8 months ago by tapted
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MobileMenuDataSaverOpened to actions.xml. The metric was added to java code in r461299 but actions.xml not updated. Resolves a presubmit failure trying to modify actions.xml for other reasons. BUG=702799 R=megjablon@chromium.org, isherman@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (6 generated)
tapted
https://codereview.chromium.org/2801693002/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/2801693002/diff/1/tools/metrics/actions/actions.xml#newcode9799 tools/metrics/actions/actions.xml:9799: <description>User pressed the Data Saver item in the app ...
3 years, 8 months ago (2017-04-05 12:31:51 UTC) #6
megjablon (incorrect)
Thanks for catching this. LGTM.
3 years, 8 months ago (2017-04-05 18:07:42 UTC) #8
megjablon
On 2017/04/05 18:07:42, megjablon (incorrect) wrote: > Thanks for catching this. LGTM. Actually looks like ...
3 years, 8 months ago (2017-04-05 18:11:33 UTC) #9
tapted
3 years, 8 months ago (2017-04-05 22:54:50 UTC) #10
On 2017/04/05 18:11:33, megjablon wrote:
> On 2017/04/05 18:07:42, megjablon (incorrect) wrote:
> > Thanks for catching this. LGTM.
> 
> Actually looks like this was already caught here
> https://codereview.chromium.org/2804683002

Ah, thanks for the link! I'll close this.

Powered by Google App Engine
This is Rietveld 408576698