Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2801603009:
Deserialize frame_token in CompositorFrameMetadata's struct traits (Closed)
|
Created:
3 years, 8 months ago by Saman Sami Modified:
3 years, 8 months ago CC:
chromium-reviews, cc-bugs_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionDeserialize frame_token in CompositorFrameMetadata's struct traits
In my last CL I added the serialization code but not deserialization.
TBR=danakj@chromium.org
BUG=704972
Review-Url: https://codereview.chromium.org/2801603009
Cr-Commit-Position: refs/heads/master@{#462697}
Committed: https://chromium.googlesource.com/chromium/src/+/a1c5ca581b5d6b97b4b150fb32125055a678dca2
Patch Set 1 #Patch Set 2 : Update unit test #
Messages
Total messages: 24 (18 generated)
Description was changed from ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 ========== to ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
Description was changed from ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
samans@chromium.org changed reviewers: + tsepez@chromium.org
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by samans@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by samans@chromium.org
The CQ bit was checked by samans@chromium.org
The CQ bit was unchecked by samans@chromium.org
Description was changed from ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 ==========
The CQ bit was checked by samans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. BUG=704972 ========== to ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. TBR=danakj@chromium.org BUG=704972 ==========
samans@chromium.org changed reviewers: + danakj@chromium.org
The CQ bit was checked by samans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491521581614250,
"parent_rev": "3e6e8c0b97d5f2e9ce4cb07403cc583d335d08ef", "commit_rev":
"a1c5ca581b5d6b97b4b150fb32125055a678dca2"}
Message was sent while issue was closed.
Description was changed from ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. TBR=danakj@chromium.org BUG=704972 ========== to ========== Deserialize frame_token in CompositorFrameMetadata's struct traits In my last CL I added the serialization code but not deserialization. TBR=danakj@chromium.org BUG=704972 Review-Url: https://codereview.chromium.org/2801603009 Cr-Commit-Position: refs/heads/master@{#462697} Committed: https://chromium.googlesource.com/chromium/src/+/a1c5ca581b5d6b97b4b150fb3212... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a1c5ca581b5d6b97b4b150fb3212... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
