DevTools: simplify ScriptFormatterEditorAction

Simplify ScriptFormatterEditorAction

- use symbols to map scripts and UISourceCodes to FormatData;
- make FormatterScriptMapping independent on both debugger model and
    editor action;
- make FormatData agnostic of source code type, just keep original
    and formatted source codes.

Review-Url: https://codereview.chromium.org/2801543002
Cr-Commit-Position: refs/heads/master@{#462756}
Committed: https://chromium.googlesource.com/chromium/src/+/ffd62e54dade66c69d8db05c71cf5a0a2f923012

[caseq, 2017-04-05 01:19:01]

caseq@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[pfeldman, 2017-04-05 18:23:35]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-04-05 18:23:36]

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
(right):

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:37:
var scripts =
Sources.ScriptFormatterEditorAction._scriptsForUISourceCode(formatData.originalSourceCode);
You are formatting UISourceCodes, not scripts. Formatter should take the text
from the UISourceCode, format it, store a pointer to the original UISourceCode.

To perform the UI -> Raw transformation, you should use formatting mapping to
get UILocation for the original formatter UISourceCode and then use debugger
workspace binding to move into the raw terms. You action should not operate on
scripts and script arrays.

To perform the Raw -> UI transformation, you should use debugger workspace
binding to jump to the original UI terms first and then use formatting data to
move into UI.

[lushnikov, 2017-04-05 18:29:48]

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
(right):

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:33:
var formatData =
uiSourceCode[Sources.ScriptFormatterEditorAction._formatDataSymbol];
don't you want to save script here instead?

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:37:
var scripts =
Sources.ScriptFormatterEditorAction._scriptsForUISourceCode(formatData.originalSourceCode);
let's bind formatted UISourceCode to a single script

[pfeldman, 2017-04-06 00:46:26]

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
(right):

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:16:
var formatData = script &&
script[Sources.ScriptFormatterEditorAction._formatDataSymbol];
type cast it?

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:19:
var lineNumber = rawLocation.lineNumber;
inline those two

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:40:
return scripts[0].debuggerModel.createRawLocation(scripts[0],
originalLocation[0], originalLocation[1]);
We'll burn in hell for this.

https://codereview.chromium.org/2801543002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:237:
var formatData = script[Sources.ScriptFormatterEditorAction._formatDataSymbol];
cast

[pfeldman, 2017-04-06 00:46:33]

lgtm

[caseq, 2017-04-07 01:02:25]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-04-07 01:02:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2801543002/#ps40001
(title: "fixed cleanup")

[commit-bot: I haz the power, 2017-04-07 01:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:00:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491526945015610,
"parent_rev": "78d4b1d3374ed443db47841d65922619fa2441e1", "commit_rev":
"ffd62e54dade66c69d8db05c71cf5a0a2f923012"}

[commit-bot: I haz the power, 2017-04-07 05:01:16]

Description was changed from

==========
Simplify ScriptFormatterEditorAction

- use symbols to map scripts and UISourceCodes to FormatData;
- make FormatterScriptMapping independent on both debugger model and
    editor action;
- make FormatData agnostic of source code type, just keep original
    and formatted source codes.
==========

to

==========
Simplify ScriptFormatterEditorAction

- use symbols to map scripts and UISourceCodes to FormatData;
- make FormatterScriptMapping independent on both debugger model and
    editor action;
- make FormatData agnostic of source code type, just keep original
    and formatted source codes.

Review-Url: https://codereview.chromium.org/2801543002
Cr-Commit-Position: refs/heads/master@{#462756}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffd62e54dade66c69d8db05c71cf...
==========

[commit-bot: I haz the power, 2017-04-07 05:01:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ffd62e54dade66c69d8db05c71cf...