Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2009)

Unified Diff: build/android/gyp/util/proguard_util.py

Issue 2801443002: Filter extra output introduced by updating proguard (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/util/proguard_util.py
diff --git a/build/android/gyp/util/proguard_util.py b/build/android/gyp/util/proguard_util.py
index a965ff33271df95f81f4f3f31f6ebe2c24416af7..8e158f0a2f6a882f87b59a1a836eb57420e4fb8b 100644
--- a/build/android/gyp/util/proguard_util.py
+++ b/build/android/gyp/util/proguard_util.py
@@ -19,14 +19,22 @@ class _ProguardOutputFilter(object):
def __init__(self):
self._last_line_ignored = False
+ self._to_ignore_next_line = False
agrieve 2017/04/04 20:05:51 nit: _to_ignore_next_line -> _ignore_next_line
F 2017/04/04 20:38:07 Done.
def __call__(self, output):
ret = []
for line in output.splitlines(True):
+ if self._to_ignore_next_line:
+ self._to_ignore_next_line = False
+ continue
+
if not line.startswith(' '):
self._last_line_ignored = bool(self.IGNORE_RE.match(line))
elif 'You should check if you need to specify' in line:
self._last_line_ignored = True
+ elif '***BINARY RUN STATS***' in line:
+ self._last_line_ignored = True
+ self._to_ignore_next_line = True
if not self._last_line_ignored:
ret.append(line)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698