Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2801433003: Form submission with blank target is broken. (Closed)

Created:
3 years, 8 months ago by michaeldo
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Form submission with blank target is broken. The UIWebView's implementation required a call to register the load of the form post request. However, this is no longer needed with WKWebView's callbacks. This removes the early |registerLoadRequest:referrer:transition:| call which was added for UIWebView and is no longer needed. TEST=Test that popups are blocked when expected, and shown when the user initiates them. I used popuptest.com to validate and there is also a link at the bottom of the page to “good” user-initiated popups that should not be blocked. The results looked good to me after this change. BUG=702755 Review-Url: https://codereview.chromium.org/2763173002 Cr-Commit-Position: refs/heads/master@{#460688} (cherry picked from commit 9736d7d0d0c9999c239e43486a901b1f4a61cbdd) Review-Url: https://codereview.chromium.org/2801433003 . Cr-Commit-Position: refs/branch-heads/3029@{#580} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/dcc0449c184655ff23ce4cfdc098692055b25da1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M ios/web/web_state/js/resources/core.js View 1 chunk +3 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
michaeldo
3 years, 8 months ago (2017-04-04 20:51:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcc0449c184655ff23ce4cfdc098692055b25da1.

Powered by Google App Engine
This is Rietveld 408576698