[DevTools] Listen to mousedown in SoftContextMenu once

[DevTools] Listen to mousedown in SoftContextMenu once

We used to handle that through GlassPane, which has problems
with multiple layers of SoftContextMenus. Now we have a single
listener on bubble, and cancel all menus at that point.

BUG=709350
Review-Url: https://codereview.chromium.org/2801373002
Cr-Commit-Position: refs/heads/master@{#463032}
Committed: https://chromium.googlesource.com/chromium/src/+/9d09b0aeddb1407f22981575e6b4fd8473830c5d

[dgozman, 2017-04-07 18:54:57]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-04-07 18:54:58]

Could you please take a look?

[dgozman, 2017-04-07 18:57:13]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 18:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:51:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:51:11]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-04-07 22:25:40]

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (left):

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:53:
this._glassPane.setSetOutsideClickCallback(event => {
can we fix the setSetOutsideClickCallback name?

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:55:
event.consume();
why does the bug happen in the first place? As far as I see on a video in the
bug, the click doesn't happen outside.

[dgozman, 2017-04-07 22:30:32]

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js (left):

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:53:
this._glassPane.setSetOutsideClickCallback(event => {
On 2017/04/07 22:25:40, lushnikov wrote:
> can we fix the setSetOutsideClickCallback name?

Yeah, in a separate patch?

https://codereview.chromium.org/2801373002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/SoftContextMenu.js:55:
event.consume();
On 2017/04/07 22:25:40, lushnikov wrote:
> why does the bug happen in the first place? As far as I see on a video in the
> bug, the click doesn't happen outside.

This is because we have two nested menus, and click in one menu happens outside
of the other menu.

[lushnikov, 2017-04-07 22:36:31]

thanks, lgtm!

[dgozman, 2017-04-07 22:40:59]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:41:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:59:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491604859292570, "parent_rev":
"e4b092f17442ceb6ff2dbf9899f626f7b908f916", "commit_rev":
"9d09b0aeddb1407f22981575e6b4fd8473830c5d"}

[commit-bot: I haz the power, 2017-04-07 23:00:54]

Description was changed from

==========
[DevTools] Listen to mousedown in SoftContextMenu once

We used to handle that through GlassPane, which has problems
with multiple layers of SoftContextMenus. Now we have a single
listener on bubble, and cancel all menus at that point.

BUG=709350
==========

to

==========
[DevTools] Listen to mousedown in SoftContextMenu once

We used to handle that through GlassPane, which has problems
with multiple layers of SoftContextMenus. Now we have a single
listener on bubble, and cancel all menus at that point.

BUG=709350

Review-Url: https://codereview.chromium.org/2801373002
Cr-Commit-Position: refs/heads/master@{#463032}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d09b0aeddb1407f22981575e6b4...
==========

[commit-bot: I haz the power, 2017-04-07 23:00:55]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d09b0aeddb1407f22981575e6b4...