[CrOS Tether] Fill out the Initializer class. Tether will now initialize fully once the flag is ena…

chrome/browser/chromeos/login/session/user_session_manager.cc

Index: chrome/browser/chromeos/login/session/user_session_manager.cc
diff --git a/chrome/browser/chromeos/login/session/user_session_manager.cc b/chrome/browser/chromeos/login/session/user_session_manager.cc
index 68980b751c0277c7786b41141bbc1412dfd3c77f..2ec14267a95e0f6fbfe302c6c1100f38fb2cb0f8 100644
--- a/chrome/browser/chromeos/login/session/user_session_manager.cc
+++ b/chrome/browser/chromeos/login/session/user_session_manager.cc
@@ -57,6 +57,7 @@
 #include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/supervised_user_manager.h"
 #include "chrome/browser/chromeos/login/wizard_controller.h"
+#include "chrome/browser/chromeos/net/tether_notification_presenter.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
@@ -73,6 +74,7 @@
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/easy_unlock_service.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/supervised_user/child_accounts/child_account_service.h"
 #include "chrome/browser/supervised_user/child_accounts/child_account_service_factory.h"
@@ -1255,7 +1257,10 @@ void UserSessionManager::FinalizePrepareProfile(Profile* profile) {
     if (base::CommandLine::ForCurrentProcess()->HasSwitch(
             chromeos::switches::kEnableTether)) {
       chromeos::tether::Initializer::Initialize(
-          ChromeCryptAuthServiceFactory::GetForBrowserContext(profile));
+          ChromeCryptAuthServiceFactory::GetForBrowserContext(profile),
+          base::MakeUnique<tether::TetherNotificationPresenter>(),

[stevenjb, 2017/04/10 20:26:59]

See my comment in https://codereview.chromium.org/2805393002/. Also, this is a
little bit subtle. I would prefer to see:

auto presenter = base::MakeUnique<tether::TetherNotificationPresenter>(
  message_center::MessageCenter::Get(),
  NetworkConnect::Get());

chromeos::tether::Initializer::Initialize(..., std::move(presenter), ...);

Also, please ensure that UserSessionManager is destroyed *before*
NetworkHandler::Shutdown is called here:

https://cs.chromium.org/chromium/src/chrome/browser/chromeos/chrome_browser_m...

*And* before MessageCenter::Shutdown:

https://cs.chromium.org/chromium/src/chrome/browser/browser_process_impl.cc?t...

[Kyle Horimoto, 2017/04/11 01:40:40]

Done.

+          profile->GetPrefs(),
+          ProfileOAuth2TokenServiceFactory::GetForProfile(profile));
     }
   }