[CrOS Tether] Fill out the Initializer class. Tether will now initialize fully once the flag is ena…

chromeos/components/tether/host_scanner.h

Index: chromeos/components/tether/host_scanner.h
diff --git a/chromeos/components/tether/host_scanner.h b/chromeos/components/tether/host_scanner.h
index e2a3e94bb74acaab1f0f40d63f89f5abfdeaae92..164b639188690bd846f7f0b292ef8766eb48b9a8 100644
--- a/chromeos/components/tether/host_scanner.h
+++ b/chromeos/components/tether/host_scanner.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H
-#define CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H
+#ifndef CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H_
+#define CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H_
 
 #include <vector>
 
@@ -25,13 +25,11 @@ class TetherHostFetcher;
 // TODO(khorimoto): Add some sort of "staleness" timeout which removes scan
 //                  results which occurred long enough ago that they are no
 //                  longer valid.
-// TODO(hansberry): Implement handling for scan results.
 class HostScanner : public HostScannerOperation::Observer {
  public:
   HostScanner(TetherHostFetcher* tether_host_fetcher,
               BleConnectionManager* connection_manager,
               HostScanDevicePrioritizer* host_scan_device_prioritizer,
-              NetworkStateHandler* network_state_handler,
               NotificationPresenter* notification_presenter);
   virtual ~HostScanner();
 
@@ -54,6 +52,13 @@ class HostScanner : public HostScannerOperation::Observer {
 
  private:
   friend class HostScannerTest;
+  friend class HostScanSchedulerTest;
+
+  HostScanner(TetherHostFetcher* tether_host_fetcher,
+              BleConnectionManager* connection_manager,
+              HostScanDevicePrioritizer* host_scan_device_prioritizer,
+              NetworkStateHandler* network_state_handler,
+              NotificationPresenter* notification_presenter);

[stevenjb, 2017/04/10 20:26:59]

Don't do this. Multiple constructors are messy and should generally be avoided.
Also, as mentioned, this obscures lifetime issues.

[Kyle Horimoto, 2017/04/11 01:40:40]

Done.

 
   void OnTetherHostsFetched(const cryptauth::RemoteDeviceList& tether_hosts);
 
@@ -77,4 +82,4 @@ class HostScanner : public HostScannerOperation::Observer {
 
 }  // namespace chromeos
 
-#endif  // CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H
+#endif  // CHROMEOS_COMPONENTS_TETHER_HOST_SCANNER_H_