Remove MojoCompositorFrameSink::WillDrawSurface

Remove MojoCompositorFrameSink::WillDrawSurface

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801313002
Cr-Commit-Position: refs/heads/master@{#463404}
Committed: https://chromium.googlesource.com/chromium/src/+/514a2755c94d9333fb54925d3ca7a818cd40189e

[Alex Z., 2017-04-07 14:23:58]

Description was changed from

==========
Remove MojoCompositorFrameSink::WillDrawSurface

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
==========

to

==========
Remove MojoCompositorFrameSink::WillDrawSurface

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Alex Z., 2017-04-07 14:24:07]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 14:24:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-04-07 14:24:26]

staraz@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Alex Z., 2017-04-07 14:24:26]

PTAL.

[commit-bot: I haz the power, 2017-04-07 14:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 14:39:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2017-04-07 14:43:12]

https://codereview.chromium.org/2801313002/diff/1/components/exo/compositor_f...
File components/exo/compositor_frame_sink_holder.h (left):

https://codereview.chromium.org/2801313002/diff/1/components/exo/compositor_f...
components/exo/compositor_frame_sink_holder.h:51: void WillDrawSurface(const
cc::LocalSurfaceId& local_surface_id,
Can't delete this I think.

[Alex Z., 2017-04-07 14:50:57]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-04-07 14:51:04]

https://codereview.chromium.org/2801313002/diff/1/components/exo/compositor_f...
File components/exo/compositor_frame_sink_holder.h (left):

https://codereview.chromium.org/2801313002/diff/1/components/exo/compositor_f...
components/exo/compositor_frame_sink_holder.h:51: void WillDrawSurface(const
cc::LocalSurfaceId& local_surface_id,
On 2017/04/07 14:43:12, Fady Samuel wrote:
> Can't delete this I think.

It's the one in exo::CompositorFrameSink that I shouldn't have 
deleted.
It's fixed in the next patch.

[commit-bot: I haz the power, 2017-04-07 14:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 16:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 16:13:12]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-04-10 13:40:31]

lgtm

[Alex Z., 2017-04-10 13:46:05]

staraz@chromium.org changed reviewers:
+ jbroman@chromium.org, piman@chromium.org, reveman@chromium.org

[Alex Z., 2017-04-10 13:46:06]

piman@chromium.org: Please review changes in content/

reveman@chromium.org: Please review changes in exo

jbroman@chromium.org: Please review changes in WebKit

[Alex Z., 2017-04-10 13:46:32]

staraz@chromium.org changed reviewers:
+ tsepez@chromium.org

[Alex Z., 2017-04-10 13:46:33]

tsepez@: Please review changes in mojom

[Alex Z., 2017-04-10 15:03:30]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:03:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-04-10 15:53:59]

lgtm

[commit-bot: I haz the power, 2017-04-10 16:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:20:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2017-04-10 17:00:10]

components/exo lgtm % nit

https://codereview.chromium.org/2801313002/diff/40001/components/exo/composit...
File components/exo/compositor_frame_sink.cc (right):

https://codereview.chromium.org/2801313002/diff/40001/components/exo/composit...
components/exo/compositor_frame_sink.cc:71: const gfx::Rect& damage_rect) {}
nit: move definition to header now that it is empty

[jbroman, 2017-04-10 17:04:19]

lgtm

[Alex Z., 2017-04-10 17:38:35]

The CQ bit was checked by staraz@chromium.org to run a CQ dry run

[Alex Z., 2017-04-10 17:39:01]

https://codereview.chromium.org/2801313002/diff/40001/components/exo/composit...
File components/exo/compositor_frame_sink.cc (right):

https://codereview.chromium.org/2801313002/diff/40001/components/exo/composit...
components/exo/compositor_frame_sink.cc:71: const gfx::Rect& damage_rect) {}
On 2017/04/10 17:00:10, reveman wrote:
> nit: move definition to header now that it is empty

Done.

[commit-bot: I haz the power, 2017-04-10 17:39:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2017-04-10 18:11:42]

lgtm

[commit-bot: I haz the power, 2017-04-10 19:34:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:34:31]

Dry run: This issue passed the CQ dry run.

[Alex Z., 2017-04-10 21:03:48]

The CQ bit was checked by staraz@chromium.org

[Alex Z., 2017-04-10 21:03:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, tsepez@chromium.org, reveman@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2801313002/#ps60001
(title: "Address Nit")

[commit-bot: I haz the power, 2017-04-10 21:04:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 21:37:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491858228996070,
"parent_rev": "a147c6267bcb9c5321eb5e4db112a32199e92848", "commit_rev":
"514a2755c94d9333fb54925d3ca7a818cd40189e"}

[commit-bot: I haz the power, 2017-04-10 21:38:58]

Description was changed from

==========
Remove MojoCompositorFrameSink::WillDrawSurface

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove MojoCompositorFrameSink::WillDrawSurface

WillDrawSurface is no longer being used on the client side. Removing it would
reduce the number of IPCs we send.

BUG=671202
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2801313002
Cr-Commit-Position: refs/heads/master@{#463404}
Committed:
https://chromium.googlesource.com/chromium/src/+/514a2755c94d9333fb54925d3ca7...
==========

[commit-bot: I haz the power, 2017-04-10 21:39:02]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/514a2755c94d9333fb54925d3ca7...