Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2801243003: Re-enable GpuProcess_no_gpu_process on Windows Debug. (Closed)

Created:
3 years, 8 months ago by capn
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG=701625 Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801243003 Cr-Commit-Position: refs/heads/master@{#464205} Committed: https://chromium.googlesource.com/chromium/src/+/12281bd8755744a457842d926b0df999dfd5db9e

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/test/gpu/gpu_tests/gpu_process_expectations.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (19 generated)
capn
PTAL
3 years, 8 months ago (2017-04-12 05:07:58 UTC) #13
Ken Russell (switch to Gerrit)
lgtm Please feel free to TBR= such changes to me as long as they have ...
3 years, 8 months ago (2017-04-12 22:29:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801243003/40001
3 years, 8 months ago (2017-04-12 22:47:35 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 23:27:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/12281bd8755744a457842d926b0d...

Powered by Google App Engine
This is Rietveld 408576698