|
|
Chromium Code Reviews|
Created:
3 years, 8 months ago by capn Modified:
3 years, 8 months ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable GpuProcess_no_gpu_process on Windows Debug.
Debug builds of SwiftShader were creating a startup dialog for attaching a
debugger, causing the GPU process created by chrome://gpu not to exit. This has
been fixed, so the suppressed test can be enabled again.
BUG=701625
Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2801243003
Cr-Commit-Position: refs/heads/master@{#464205}
Committed: https://chromium.googlesource.com/chromium/src/+/12281bd8755744a457842d926b0df999dfd5db9e
Patch Set 1 #Patch Set 2 : Rebase. #Patch Set 3 : Rebase again. #Messages
Total messages: 23 (19 generated)
Description was changed from ========== Re-enable GpuProcess_skip_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG= Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf ========== to ========== Re-enable GpuProcess_skip_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG= Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by capn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
capn@chromium.org changed reviewers: + kbr@chromium.org
PTAL
Description was changed from ========== Re-enable GpuProcess_skip_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG= Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG= Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG= Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG=701625 Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Please feel free to TBR= such changes to me as long as they have a bug ID listed in the BUG= line.
The CQ bit was checked by capn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492037209702690,
"parent_rev": "ca7672ad2527bb65ca0a1bc76d8e369f4a4c0729", "commit_rev":
"12281bd8755744a457842d926b0df999dfd5db9e"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG=701625 Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Re-enable GpuProcess_no_gpu_process on Windows Debug. Debug builds of SwiftShader were creating a startup dialog for attaching a debugger, causing the GPU process created by chrome://gpu not to exit. This has been fixed, so the suppressed test can be enabled again. BUG=701625 Change-Id: I623ba7e0ac9e187831ffb2756300f9e2e99372cf CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2801243003 Cr-Commit-Position: refs/heads/master@{#464205} Committed: https://chromium.googlesource.com/chromium/src/+/12281bd8755744a457842d926b0d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/12281bd8755744a457842d926b0d... |
