Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2801233002: Revert of [turbofan] Better representation selection for comparison with Float64. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Better representation selection for comparison with Float64. (patchset #2 id:20001 of https://codereview.chromium.org/2790833004/ ) Reason for revert: Doesn't really move the needle, but tanks Kraken/imaging-gaussian-blur (crbug.com/709396), so reverting for now. Original issue's description: > [turbofan] Better representation selection for comparison with Float64. > > For speculative number comparisons with SignedSmall feedback, we always > enforce either TaggedSigned or Word32 comparisons. But this is not > really beneficial if one of the inputs is already in Float64 > representation; in that case it's cheaper to just convert the other > input to a Float64. > > R=jarin@chromium.org > > Review-Url: https://codereview.chromium.org/2790833004 > Cr-Commit-Position: refs/heads/master@{#44327} > Committed: https://chromium.googlesource.com/v8/v8/+/8af394d6d385daf05b73765a2545ac8f266c64c7 TBR=jarin@chromium.org BUG=chromium:709396 Review-Url: https://codereview.chromium.org/2801233002 Cr-Commit-Position: refs/heads/master@{#44480} Committed: https://chromium.googlesource.com/v8/v8/+/5e78b32d706470cddabfe776bc4c7c8411e28481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
Created Revert of [turbofan] Better representation selection for comparison with Float64.
3 years, 8 months ago (2017-04-07 10:36:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801233002/1
3 years, 8 months ago (2017-04-07 10:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801233002/1
3 years, 8 months ago (2017-04-07 10:37:17 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 11:17:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5e78b32d706470cddabfe776bc4c7c8411e...

Powered by Google App Engine
This is Rietveld 408576698