Oilpan: move LiveNodeList collections to the heap.

Source/web/tests/TouchActionTest.cpp

Index: Source/web/tests/TouchActionTest.cpp
diff --git a/Source/web/tests/TouchActionTest.cpp b/Source/web/tests/TouchActionTest.cpp
index 52d22af0fbe9091cfb3b496de42c79b6cb9fd7a2..9f3f2eacd256b1dc9e08e9d23d5973e5dcaa7b7c 100644
--- a/Source/web/tests/TouchActionTest.cpp
+++ b/Source/web/tests/TouchActionTest.cpp
@@ -147,7 +147,7 @@ void TouchActionTest::runShadowDOMTest(std::string file)
 
     WebCore::TrackExceptionState es;
     RefPtrWillBeRawPtr<WebCore::Document> document = static_cast<PassRefPtrWillBeRawPtr<WebCore::Document> >(webView->mainFrame()->document());
-    RefPtr<WebCore::NodeList> hostNodes = document->querySelectorAll("[shadow-host]", es);
+    RefPtrWillBeRawPtr<WebCore::NodeList> hostNodes = document->querySelectorAll("[shadow-host]", es);
     ASSERT_FALSE(es.hadException());
     ASSERT_GE(hostNodes->length(), 1u);
 
@@ -183,10 +183,14 @@ void TouchActionTest::runTestOnTree(WebCore::ContainerNode* root, WebView* webVi
 {
     // Find all elements to test the touch-action of in the document.
     WebCore::TrackExceptionState es;
-    RefPtr<WebCore::NodeList> nodes = root->querySelectorAll("[expected-action]", es);
+    RefPtrWillBeRawPtr<WebCore::NodeList> nodes = root->querySelectorAll("[expected-action]", es);
     ASSERT_FALSE(es.hadException());
 
     for (unsigned index = 0; index < nodes->length(); index++) {
+        // FIXME: Oilpan: long-running test that allocates; if the PendingGCRunner task
+        // is run, it GCs assuming no pointers on the stack. But there is.
+        WebCore::Heap::collectGarbage(WebCore::ThreadState::HeapPointersOnStack);

[haraken, 2014/05/12 12:04:13]

Would you elaborate on this?

- Why can PendingGCRunner run during this test?
- Even if it runs, why does it run assuming no pointers on stack even though
there is pointers on stack?

[sof, 2014/05/12 12:24:36]

The parser thread creates a pending GC runner. I don't know the answer to the
2nd, hence the FIXME, other than I assume the GC runner is meant to be run at a
safe point.

[haraken, 2014/05/12 12:36:55]

hmm, your current solution looks a bit fragile. Even if you force
Heap::collectGarbage, it's possible that the pending GC runner comes into a
play.

Probably is the condition under which the PendingGCRunner uses
HeapPointersOnStack wrong?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[sof, 2014/05/12 12:52:46]

Indeed so; I'm not proposing this as the final solution (cf FIXME).

Need a different setup for tests, perhaps? Seeking input on where best to
address this.

[sof, 2014/05/15 09:23:24]

Tried to make the FIXME comment clearer; i.e., tests either need to be set up to
run with HeapPointersOnStack, or we need to adjust the running of
PendingGCRunner.

[Mads Ager (chromium), 2014/05/15 10:54:24]

The PendingGCRunner should only run when we are back at the event loop and
therefore know that there are no pointers on the stack. Are these tests creating
a separate event loop where they pump tasks through on this thread? Can you post
a stack trace Sigbjorn? We need to understand this. Something is completely
wrong here. If the test is doing something nasty like that which cannot happen
in real code it seems to me that the solution is to use Persistents instead of
RawPtr for the pointers in this test method. However, I would like to understand
exactly how and when we end up getting the PendingGCRunner executed when we are
actually not back at an event loop.

[sof, 2014/05/15 11:39:41]

A nested message loop, it seems. The PendingGCRunner that triggers the GC is
initially created from:

#0  WebCore::PendingGCRunner::PendingGCRunner (this=0x6cd6440) at
../../third_party/WebKit/Source/platform/heap/glue/PendingGCRunner.h:41
#1  0x000000000146b45f in blink::initializeWithoutV8 (platform=0x6c5f0e8) at
../../third_party/WebKit/Source/web/WebKit.cpp:163
#2  0x000000000146b0cf in blink::initialize (platform=0x6c5f0e8) at
../../third_party/WebKit/Source/web/WebKit.cpp:98
#3  0x000000000080f42c in
content::TestWebKitPlatformSupport::TestWebKitPlatformSupport (this=0x6c5f0e0)
at ../../content/test/test_webkit_platform_support.cc:48
#4  0x000000000080e460 in content::(anonymous
namespace)::TestEnvironment::TestEnvironment (this=0x6c5e120) at
../../content/test/webkit_support.cc:63
#5  0x000000000080e4e0 in content::SetUpTestEnvironmentForUnitTests () at
../../content/test/webkit_support.cc:111
#6  0x000000000080e111 in content::SetUpTestEnvironmentForWebKitUnitTests () at
../../content/test/webkit_unit_test_support.cc:12
#7  0x0000000000417c67 in main (argc=1, argv=0x7fffffffdea8) at
../../third_party/WebKit/Source/web/tests/RunAllTests.cpp:63

with a "no heap pointers on stack" GC then happening later on,

#0  WebCore::Heap::collectGarbage
(stackState=WebCore::ThreadState::NoHeapPointersOnStack) at
../../third_party/WebKit/Source/platform/heap/Heap.cpp:1631
#1  0x00000000009511c3 in WebCore::ThreadState::performPendingGC (this=0x6b7c900
<WebCore::ThreadState::s_mainThreadStateStorage>,
stackState=WebCore::ThreadState::NoHeapPointersOnStack)
    at ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp:638
#2  0x0000000000951796 in WebCore::ThreadState::safePoint (this=0x6b7c900
<WebCore::ThreadState::s_mainThreadStateStorage>,
stackState=WebCore::ThreadState::NoHeapPointersOnStack)
    at ../../third_party/WebKit/Source/platform/heap/ThreadState.cpp:738
#3  0x000000000146bcfa in WebCore::PendingGCRunner::didProcessTask
(this=0x6cd6440) at
../../third_party/WebKit/Source/platform/heap/glue/PendingGCRunner.h:64
#4  0x0000000002fb31b1 in
content::WebThreadBase::TaskObserverAdapter::DidProcessTask (this=0x6cd64a0,
pending_task=...) at ../../content/child/webthread_impl.cc:32
#5  0x00000000030d2a46 in base::MessageLoop::RunTask (this=0x6c5e530,
pending_task=...) at ../../base/message_loop/message_loop.cc:451
#6  0x00000000030d2b12 in base::MessageLoop::DeferOrRunPendingTask
(this=0x6c5e530, pending_task=...) at
../../base/message_loop/message_loop.cc:462
#7  0x00000000030d3055 in base::MessageLoop::DoWork (this=0x6c5e530) at
../../base/message_loop/message_loop.cc:576
#8  0x000000000318aa81 in base::MessagePumpGlib::HandleDispatch (this=0x6c5e7f0)
at ../../base/message_loop/message_pump_glib.cc:219
#9  0x000000000318a4af in base::(anonymous namespace)::WorkSourceDispatch
(source=0x6c5e8a0, unused_func=0x0, unused_data=0x0) at
../../base/message_loop/message_pump_glib.cc:107
#10 0x00007ffff6ca4f05 in g_main_dispatch (context=0x6c5ed00) at
/build/buildd/glib2.0-2.36.0/./glib/gmain.c:3054
#11 g_main_context_dispatch (context=context@entry=0x6c5ed00) at
/build/buildd/glib2.0-2.36.0/./glib/gmain.c:3630
#12 0x00007ffff6ca5248 in g_main_context_iterate
(context=context@entry=0x6c5ed00, block=block@entry=0,
dispatch=dispatch@entry=1, self=<optimized out>)
    at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3701
#13 0x00007ffff6ca5304 in g_main_context_iteration (context=0x6c5ed00,
may_block=0) at /build/buildd/glib2.0-2.36.0/./glib/gmain.c:3762
#14 0x000000000318ac67 in base::MessagePumpGlib::Run (this=0x6c5e7f0,
delegate=0x6c5e530) at ../../base/message_loop/message_pump_glib.cc:266
#15 0x00000000030d24e6 in base::MessageLoop::RunHandler (this=0x6c5e530) at
../../base/message_loop/message_loop.cc:400
#16 0x00000000031212de in base::RunLoop::Run (this=0x7fffffffcb00) at
../../base/run_loop.cc:49
#17 0x00000000030d1b9a in base::MessageLoop::Run (this=0x6c5e530) at
../../base/message_loop/message_loop.cc:293
#18 0x0000000002fb2e12 in content::WebThreadImplForMessageLoop::enterRunLoop
(this=0x6cd63e0) at ../../content/child/webthread_impl.cc:116
#19 0x000000000060e3e4 in blink::FrameTestHelpers::runPendingTasks () at
../../third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp:252
#20 0x000000000066250d in (anonymous namespace)::TouchActionTest::sendTouchEvent
(this=0x6d2a460, webView=0x109621e48010, type=blink::WebInputEvent::TouchStart,
clientPoint=...)
    at ../../third_party/WebKit/Source/web/tests/TouchActionTest.cpp:321
#21 0x00000000006615db in (anonymous namespace)::TouchActionTest::runTestOnTree
(this=0x6d2a460, root=0x7ffff7f85598, webView=0x109621e48010, client=...)
    at ../../third_party/WebKit/Source/web/tests/TouchActionTest.cpp:265
#22 0x000000000065ff8a in (anonymous
namespace)::TouchActionTest::runTouchActionTest (this=0x6d2a460, file=...) at
../../third_party/WebKit/Source/web/tests/TouchActionTest.cpp:137
#23 0x0000000000662630 in (anonymous
namespace)::TouchActionTest_Simple_Test::TestBody (this=0x6d2a460) at
../../third_party/WebKit/Source/web/tests/TouchActionTest.cpp:326
#24 0x00000000007e42cd in
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>
(object=0x6d2a460, method=&virtual testing::Test::TestBody(), 
    location=0x3ae08a3 "the test body") at ../../testing/gtest/src/gtest.cc:1989
#25 0x00000000007df809 in
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>
(object=0x6d2a460, method=&virtual testing::Test::TestBody(), 
    location=0x3ae08a3 "the test body") at ../../testing/gtest/src/gtest.cc:2042
#26 0x00000000007d3ca9 in testing::Test::Run (this=0x6d2a460) at
../../testing/gtest/src/gtest.cc:2062
#27 0x00000000007d42d2 in testing::TestInfo::Run (this=0x6c20470) at
../../testing/gtest/src/gtest.cc:2237
#28 0x00000000007d482d in testing::TestCase::Run (this=0x6c205a0) at
../../testing/gtest/src/gtest.cc:2344
#29 0x00000000007d9290 in testing::internal::UnitTestImpl::RunAllTests
(this=0x6bc7920) at ../../testing/gtest/src/gtest.cc:4065
#30 0x00000000007e56f8 in
testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool> (object=0x6bc7920, 
    method=(bool
(testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const))
0x7d8f9e <testing::internal::UnitTestImpl::RunAllTests()>, 
    location=0x3ae1110 "auxiliary test code (environments or event listeners)")
at ../../testing/gtest/src/gtest.cc:1989
#31 0x00000000007e0961 in
testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,
bool> (object=0x6bc7920, 
    method=(bool
(testing::internal::UnitTestImpl::*)(testing::internal::UnitTestImpl * const))
0x7d8f9e <testing::internal::UnitTestImpl::RunAllTests()>, 
    location=0x3ae1110 "auxiliary test code (environments or event listeners)")
at ../../testing/gtest/src/gtest.cc:2042
#32 0x00000000007d823f in testing::UnitTest::Run (this=0x6b7c060
<testing::UnitTest::GetInstance()::instance>) at
../../testing/gtest/src/gtest.cc:3700
#33 0x0000000000793627 in RUN_ALL_TESTS () at
../../testing/gtest/include/gtest/gtest.h:2231
#34 0x0000000000792f86 in base::TestSuite::Run (this=0x7fffffffdd90) at
../../base/test/test_suite.cc:206
#35 0x0000000000417c73 in main (argc=1, argv=0x7fffffffdea8) at
../../third_party/WebKit/Source/web/tests/RunAllTests.cpp:64

+
         WebCore::Element* element = toElement(nodes->item(index));
         element->scrollIntoViewIfNeeded();
         ASSERT_TRUE(nodes->item(index)->isElementNode());