Source/web/WebPageSerializerImpl.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPageSerializerImpl.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Pre-emptively GC a long runnning test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPageSerializerImpl.cpp

diff --git a/Source/web/WebPageSerializerImpl.cpp b/Source/web/WebPageSerializerImpl.cpp

index 1d9878beb7001de230221579868519dde7edf03b..fe6f0334fd36289cc4140e3fa86f76599155d87b 100644

--- a/Source/web/WebPageSerializerImpl.cpp

+++ b/Source/web/WebPageSerializerImpl.cpp

@@ -473,7 +473,7 @@ void WebPageSerializerImpl::collectTargetFrames()

// Get current using document.

Document* currentDoc = currentFrame->frame()->document();

// Go through sub-frames.

- RefPtr<HTMLCollection> all = currentDoc->all();

+ RefPtrWillBeRawPtr<HTMLCollection> all = currentDoc->all();

for (unsigned i = 0; Element* element = all->item(i); i++) {

if (!element->isHTMLElement())

« Source/web/WebFormElement.cpp ('K') | « Source/web/WebPageSerializer.cpp ('k') | Source/web/tests/TouchActionTest.cpp » ('j') | Source/web/tests/TouchActionTest.cpp » ('J')