Source/web/WebDocument.cpp - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebDocument.cpp

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase needed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebDocument.cpp

diff --git a/Source/web/WebDocument.cpp b/Source/web/WebDocument.cpp

index c4d158b97a92db416780983d580c0dbfb67585d1..d67630d9743bf1c721cd10459ac1e24ff7f3da8b 100644

--- a/Source/web/WebDocument.cpp

+++ b/Source/web/WebDocument.cpp

@@ -159,7 +159,7 @@ WebElementCollection WebDocument::all()

void WebDocument::images(WebVector<WebElement>& results)

{

- RefPtr<HTMLCollection> images = unwrap<Document>()->images();

+ RefPtrWillBeRawPtr<HTMLCollection> images = unwrap<Document>()->images();

size_t sourceLength = images->length();

Vector<WebElement> temp;

temp.reserveCapacity(sourceLength);

@@ -173,7 +173,7 @@ void WebDocument::images(WebVector<WebElement>& results)

void WebDocument::forms(WebVector<WebFormElement>& results) const

{

- RefPtr<HTMLCollection> forms = const_cast<Document*>(constUnwrap<Document>())->forms();

+ RefPtrWillBeRawPtr<HTMLCollection> forms = const_cast<Document*>(constUnwrap<Document>())->forms();

size_t sourceLength = forms->length();

Vector<WebFormElement> temp;

temp.reserveCapacity(sourceLength);

« Source/core/dom/StaticNodeList.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/web/WebElementCollection.cpp » ('j') | public/web/WebNode.h » ('J')