public/web/WebNode.h - Issue 280123002: Oilpan: move LiveNodeList collections to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebNode.h

Issue 280123002: Oilpan: move LiveNodeList collections to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase needed Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebNode.h

diff --git a/public/web/WebNode.h b/public/web/WebNode.h

index 785514fce17a5be10f7d5d730c328e91722d120d..ba967ff76021db935fd113421c82374c7960c065 100644

--- a/public/web/WebNode.h

+++ b/public/web/WebNode.h

@@ -144,6 +144,18 @@ public:

WebNode(const PassRefPtrWillBeRawPtr<WebCore::Node>&);

WebNode& operator=(const PassRefPtrWillBeRawPtr<WebCore::Node>&);

operator PassRefPtrWillBeRawPtr<WebCore::Node>() const;

+#if ENABLE(OILPAN)

+ // This constructor enables creation of WebNodes from Members

tkent 2014/05/19 07:23:40 Sounds reasonable.

+ // holding WebCore::Node-derived objects (this shows up in WebVector

+ // assignments, for instance.) It is needed because a RawPtr<T> constructor

+ // from a Member<U> isn't provided, hence the above constructor

+ // won't be usable.

haraken 2014/05/19 09:19:50 Yeah, probably sounds reasonable. It might be pos

+ template<typename U>

+ WebNode(const WebCore::Member<U>& other, EnsurePtrConvertibleArgDecl(U, WebCore::Node))

+ : m_private(other.get())

+ {

+ }

+#endif

#endif

#if BLINK_IMPLEMENTATION

« Source/core/dom/StaticNodeList.cpp ('K') | « public/web/WebElementCollection.h ('k') | public/web/WebNodeList.h » ('j') | no next file with comments »