Eliminate extra Native->JS->Native roundrip when showing context menu.

Eliminate extra Native->JS->Native roundrip when showing context menu.

Context menu presentation success relies on performance of
getElementFromPoint. If getElementFromPoint returns after long press
was recognized then Chrome misses the chance to show context menu and
WKWebView context menu shows up.

Merged |fetchWebPageWidthWithCompletionHandler:| and
|__gCrWeb.getElementFromPoint|  together to improve script execution
speed. This should make Chrome context menu failures less frequent. 

BUG=542933
Review-Url: https://codereview.chromium.org/2801213004
Cr-Commit-Position: refs/heads/master@{#463288}
Committed: https://chromium.googlesource.com/chromium/src/+/b35602e4c8046e6d97e65b2cd35036c29984ec9e

[Eugene But (OOO till 7-30), 2017-04-07 17:51:56]

Description was changed from

==========
Eliminate extra Native->JS->Native roundrip when showing context menu.

BUG=542933
==========

to

==========
Eliminate extra Native->JS->Native roundrip when showing context menu.

Context menu presentation success relies on performance of
getElementFromPoint. If getElementFromPoint returns after long press
was recognized then Chrome misses the chance to show context menu and
WKWebView context menu shows up.

Merged |fetchWebPageWidthWithCompletionHandler:| and
|__gCrWeb.getElementFromPoint|  together to improve script execution
speed. This should make Chrome context menu failures less frequent. 

BUG=542933
==========

[Eugene But (OOO till 7-30), 2017-04-07 17:52:20]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:26:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:26:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Eugene But (OOO till 7-30), 2017-04-07 22:30:35]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:31:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:43:54]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-04-08 00:41:49]

eugenebut@chromium.org changed reviewers:
+ michaeldo@chromium.org

[michaeldo, 2017-04-10 16:08:02]

lgtm!

[Eugene But (OOO till 7-30), 2017-04-10 16:09:24]

Thanks! I believe that eg test failure is unrelated to this change.

[Eugene But (OOO till 7-30), 2017-04-10 16:09:28]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:24:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491840568140560,
"parent_rev": "d0c1239fccdfe80d9103a9eb45415b8664f5a736", "commit_rev":
"b35602e4c8046e6d97e65b2cd35036c29984ec9e"}

[commit-bot: I haz the power, 2017-04-10 16:25:36]

Description was changed from

==========
Eliminate extra Native->JS->Native roundrip when showing context menu.

Context menu presentation success relies on performance of
getElementFromPoint. If getElementFromPoint returns after long press
was recognized then Chrome misses the chance to show context menu and
WKWebView context menu shows up.

Merged |fetchWebPageWidthWithCompletionHandler:| and
|__gCrWeb.getElementFromPoint|  together to improve script execution
speed. This should make Chrome context menu failures less frequent. 

BUG=542933
==========

to

==========
Eliminate extra Native->JS->Native roundrip when showing context menu.

Context menu presentation success relies on performance of
getElementFromPoint. If getElementFromPoint returns after long press
was recognized then Chrome misses the chance to show context menu and
WKWebView context menu shows up.

Merged |fetchWebPageWidthWithCompletionHandler:| and
|__gCrWeb.getElementFromPoint|  together to improve script execution
speed. This should make Chrome context menu failures less frequent. 

BUG=542933

Review-Url: https://codereview.chromium.org/2801213004
Cr-Commit-Position: refs/heads/master@{#463288}
Committed:
https://chromium.googlesource.com/chromium/src/+/b35602e4c8046e6d97e65b2cd350...
==========

[commit-bot: I haz the power, 2017-04-10 16:25:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b35602e4c8046e6d97e65b2cd350...

[danyao, 2017-04-10 17:53:06]

danyao@chromium.org changed reviewers:
+ danyao@chromium.org

[danyao, 2017-04-10 17:53:07]

https://codereview.chromium.org/2801213004/diff/40001/ios/web/web_state/js/co...
File ios/web/web_state/js/core_js_unittest.mm (right):

https://codereview.chromium.org/2801213004/diff/40001/ios/web/web_state/js/co...
ios/web/web_state/js/core_js_unittest.mm:24: struct TestScriptAndExpectedValue {
Can we remove this struct now? It's no longer used anywhere in this test.

[danyao, 2017-04-10 18:32:57]

https://codereview.chromium.org/2801213004/diff/40001/ios/web/web_state/js/co...
File ios/web/web_state/js/core_js_unittest.mm (right):

https://codereview.chromium.org/2801213004/diff/40001/ios/web/web_state/js/co...
ios/web/web_state/js/core_js_unittest.mm:24: struct TestScriptAndExpectedValue {
Never mind. I was blind and missed the usage in stringify().