Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2801213003: Fix UI style of signin AlertDialogs on Android (Closed)

Created:
3 years, 8 months ago by bsazonov
Modified:
3 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UI style of signin AlertDialogs on Android This CL adds SigninAlertDialogTheme style that uses Google Blue 500 color for button text and forces message text to use Chrome default text color. BUG=650121, 669787 Review-Url: https://codereview.chromium.org/2801213003 Cr-Commit-Position: refs/heads/master@{#462853} Committed: https://chromium.googlesource.com/chromium/src/+/175d75afa30ba7c98b3c183e21edf233aaa9269f

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
bsazonov
Bernhard, please take a look.
3 years, 8 months ago (2017-04-07 12:58:37 UTC) #4
Bernhard Bauer
LGTM, but can you add before and after screenshots to the CL?
3 years, 8 months ago (2017-04-07 13:28:00 UTC) #7
bsazonov
On 2017/04/07 13:28:00, Bernhard Bauer wrote: > LGTM, but can you add before and after ...
3 years, 8 months ago (2017-04-07 13:46:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801213003/1
3 years, 8 months ago (2017-04-07 14:30:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 14:36:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/175d75afa30ba7c98b3c183e21ed...

Powered by Google App Engine
This is Rietveld 408576698