Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2801193002: [Polymer] update paper-slider for RTL support (Closed)

Created:
3 years, 8 months ago by dschuyler
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Polymer] update paper-slider for RTL support This CL applies a pull request submitted to Polymer to add RTL support for paper-sliders. BUG=696437 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2801193002 Cr-Commit-Position: refs/heads/master@{#462953} Committed: https://chromium.googlesource.com/chromium/src/+/6a6df4ec7e64dfc890c6450cd4a86e39f6754da1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -68 lines) Patch
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js View 5 chunks +34 lines, -3 lines 1 comment Download
M third_party/polymer/v1_0/components_summary.txt View 1 chunk +62 lines, -62 lines 1 comment Download
M third_party/web-animations-js/sources/.bower.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
https://codereview.chromium.org/2801193002/diff/1/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js File third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js (right): https://codereview.chromium.org/2801193002/diff/1/third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js#newcode304 third_party/polymer/v1_0/components-chromium/paper-slider/paper-slider-extracted.js:304: } This is a change that wasn't in my ...
3 years, 8 months ago (2017-04-07 03:00:00 UTC) #3
Dan Beam
lgtm
3 years, 8 months ago (2017-04-07 06:13:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801193002/1
3 years, 8 months ago (2017-04-07 19:10:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 19:18:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a6df4ec7e64dfc890c6450cd4a8...

Powered by Google App Engine
This is Rietveld 408576698