Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2801173004: Add '.mojom' suffix for battery mojom modules. (Closed)

Created:
3 years, 8 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, mlamouri+watch-blink_chromium.org, mac-reviews_chromium.org, abarth-chromium, Aaron Boodman, blink-reviews, yzshen+watch_chromium.org, agrieve+watch_chromium.org, haraken, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add '.mojom' suffix for battery mojom modules. This is to prepare for moving all battery codes from //device/battery/ into //services/device/battery/. BUG=684422 TBR=rockot@chromium.org for mechanical changes in services/device/ Review-Url: https://codereview.chromium.org/2801173004 Cr-Commit-Position: refs/heads/master@{#463113} Committed: https://chromium.googlesource.com/chromium/src/+/6ff361f672aceea93e56d10189c7a2f150dcf415

Patch Set 1 #

Patch Set 2 : Rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -105 lines) Patch
M content/browser/battery_status/battery_monitor_impl_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorFactory.java View 1 chunk +2 lines, -2 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryMonitorImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M device/battery/android/java/src/org/chromium/device/battery/BatteryStatusManager.java View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/android/javatests/src/org/chromium/device/battery/BatteryStatusManagerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_monitor.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M device/battery/battery_monitor_impl.h View 1 chunk +7 lines, -6 lines 0 comments Download
M device/battery/battery_monitor_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/battery/battery_status.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_status_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_status_manager_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/battery/battery_status_manager_linux_unittest.cc View 28 chunks +32 lines, -30 lines 0 comments Download
M device/battery/battery_status_manager_mac.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M device/battery/battery_status_manager_win.h View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_status_manager_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M device/battery/battery_status_manager_win_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M device/battery/battery_status_service.h View 2 chunks +6 lines, -5 lines 0 comments Download
M device/battery/battery_status_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M device/battery/battery_status_service_unittest.cc View 7 chunks +8 lines, -10 lines 0 comments Download
M services/device/android/java/src/org/chromium/services/device/InterfaceRegistrar.java View 1 chunk +1 line, -1 line 0 comments Download
M services/device/device_service.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M services/device/device_service.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M services/device/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (17 generated)
leonhsl(Using Gerrit)
Hi, this CL has no code behavior change, needs your stamps :) Tim: all battery ...
3 years, 8 months ago (2017-04-07 09:38:40 UTC) #9
timvolodine
On 2017/04/07 09:38:40, leonhsl wrote: > Hi, this CL has no code behavior change, needs ...
3 years, 8 months ago (2017-04-07 11:34:24 UTC) #12
Tom Sepez
Stampity Stamp LGTM for adding namespace.
3 years, 8 months ago (2017-04-07 17:38:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801173004/20001
3 years, 8 months ago (2017-04-07 23:53:21 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/406101)
3 years, 8 months ago (2017-04-08 00:03:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801173004/40001
3 years, 8 months ago (2017-04-08 00:05:53 UTC) #21
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 02:55:38 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6ff361f672aceea93e56d10189c7...

Powered by Google App Engine
This is Rietveld 408576698