Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2801153002: Ship navigator.vibrate behind featurePolicyExperimentalFeatures flag (Closed)

Created:
3 years, 8 months ago by lunalu1
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship navigator.vibrate behind featurePolicyExperimentalFeatures flag Due to complexity between user gesture and vibrate, we decided to remove vibrate from V1 feature policy. Review-Url: https://codereview.chromium.org/2801153002 Cr-Commit-Position: refs/heads/master@{#462893} Committed: https://chromium.googlesource.com/chromium/src/+/a2d89c5a6fa3fe654c6db8e5737be78d4f60d4f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
lunalu1
Hi haraken, could you PTAL
3 years, 8 months ago (2017-04-06 20:17:55 UTC) #3
haraken
LGTM (I'm assuming that you've reached consensus that removing vibrate from the feature policy is ...
3 years, 8 months ago (2017-04-07 01:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801153002/1
3 years, 8 months ago (2017-04-07 15:33:31 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 16:50:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2d89c5a6fa3fe654c6db8e5737b...

Powered by Google App Engine
This is Rietveld 408576698