Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2801143002: Set WebViewImpl's size in OOPIF processes. (Closed)

Created:
3 years, 8 months ago by kenrb
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, blink-reviews, kinuko+watch, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Set WebViewImpl's size in OOPIF processes. In an OOPIF process with a remote main frame, currently the size of the WebViewImpl is not set, because it is not relevant when there is no main frame to render. However, the VisualViewport size is required so OOPIF resizes set it appropriately. This has caused a problem during printing because it saves and then restores the WebViewImpl size, which unfortunately also wipes out the VisualViewport size. This CL sets the WebViewImpl size along with the VisualViewport in order to keep them consistent. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation BUG=705867 Review-Url: https://codereview.chromium.org/2801143002 Cr-Commit-Position: refs/heads/master@{#462927} Committed: https://chromium.googlesource.com/chromium/src/+/931d158f73d21b37bad43543239a7da2f587ff0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
kenrb
dcheng: WDYT? I'm not sure this change warrants a test, since I don't see a ...
3 years, 8 months ago (2017-04-07 16:36:27 UTC) #7
dcheng
LGTM
3 years, 8 months ago (2017-04-07 17:38:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801143002/1
3 years, 8 months ago (2017-04-07 18:05:26 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 18:18:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/931d158f73d21b37bad43543239a...

Powered by Google App Engine
This is Rietveld 408576698