|
|
DescriptionMake login screen apps enabled by default
Invert the command line guard flag, so that the apps on the login screen
are enabled by default now, but can be disabled using the
--disable-login-screen-apps flag. (The flag will be removed after some
time once this change is tested and verified.)
Also open up the corresponding policy DeviceLoginScreenAppInstallList,
with updating its supported range to M60+.
The policy description is extended to mention the security and privacy
constraints that are imposed on it.
BUG=576464
Review-Url: https://codereview.chromium.org/2801113002
Cr-Commit-Position: refs/heads/master@{#471010}
Committed: https://chromium.googlesource.com/chromium/src/+/b4c388b2af93a40a40ebccd3a448c309384b97c1
Patch Set 1 #Patch Set 2 : Make login screen apps enabled by default #Patch Set 3 : Rebase #Patch Set 4 : Fix rebase #Patch Set 5 : Rebase #
Messages
Total messages: 87 (79 generated)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
Description was changed from ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M59+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 ========== to ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M59+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 ==========
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #6 (id:100001) has been deleted
Patchset #5 (id:80001) has been deleted
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
emaxx@chromium.org changed reviewers: + achuith@chromium.org
Achuith: Adding you for a tentative review. I think we shouldn't land this before the end-to-end browser test is written, but maybe you'd want to provide some early feedback on this change.
lgtm for 59. Let's wait for 1 week after M59 branch point to land this, around Apr 20. We have the flexibility to disable again right before M60 branch point if we're worried that there's some risk. In the meantime, we may be able to find some bugs in developer builds or canaries.
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Description was changed from ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M59+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 ========== to ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M60+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
emaxx@chromium.org changed reviewers: + finnur@chromium.org, skuhne@chromium.org
+OWNERS finnur@: Please review changes at chrome/browser/extensions/. skuhne@: Please review changes at chrome/browser/profiles/profile_manager.cc. Thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
profile_manager lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
chrome/browser/extensions/ OWNERS LGTM
The CQ bit was checked by emaxx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/05/11 03:58:38, Mr4D (IO delays) wrote: > profile_manager lgtm On 2017/05/11 11:17:18, Finnur wrote: > chrome/browser/extensions/ OWNERS LGTM Thanks all!
The CQ bit was checked by emaxx@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2801113002/#ps180001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 180001, "attempt_start_ts": 1494525672729500, "parent_rev": "3b2a27989ad0d93dcefd88c7f63fcb0e893b1c2c", "commit_rev": "b4c388b2af93a40a40ebccd3a448c309384b97c1"}
Message was sent while issue was closed.
Description was changed from ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M60+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 ========== to ========== Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M60+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 Review-Url: https://codereview.chromium.org/2801113002 Cr-Commit-Position: refs/heads/master@{#471010} Committed: https://chromium.googlesource.com/chromium/src/+/b4c388b2af93a40a40ebccd3a448... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:180001) as https://chromium.googlesource.com/chromium/src/+/b4c388b2af93a40a40ebccd3a448... |