Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2801113002: Make login screen apps enabled by default (Closed)

Created:
3 years, 8 months ago by emaxx
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, tnagel+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make login screen apps enabled by default Invert the command line guard flag, so that the apps on the login screen are enabled by default now, but can be disabled using the --disable-login-screen-apps flag. (The flag will be removed after some time once this change is tested and verified.) Also open up the corresponding policy DeviceLoginScreenAppInstallList, with updating its supported range to M60+. The policy description is extended to mention the security and privacy constraints that are imposed on it. BUG=576464 Review-Url: https://codereview.chromium.org/2801113002 Cr-Commit-Position: refs/heads/master@{#471010} Committed: https://chromium.googlesource.com/chromium/src/+/b4c388b2af93a40a40ebccd3a448c309384b97c1

Patch Set 1 #

Patch Set 2 : Make login screen apps enabled by default #

Patch Set 3 : Rebase #

Patch Set 4 : Fix rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -47 lines) Patch
M chrome/browser/chromeos/policy/signin_profile_apps_policy_browsertest.cc View 1 2 3 4 3 chunks +8 lines, -24 lines 0 comments Download
M chrome/browser/extensions/chrome_process_manager_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_startup_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 87 (79 generated)
emaxx
Achuith: Adding you for a tentative review. I think we shouldn't land this before the ...
3 years, 8 months ago (2017-04-11 23:37:33 UTC) #46
achuithb
lgtm for 59. Let's wait for 1 week after M59 branch point to land this, ...
3 years, 8 months ago (2017-04-11 23:45:22 UTC) #47
emaxx
+OWNERS finnur@: Please review changes at chrome/browser/extensions/. skuhne@: Please review changes at chrome/browser/profiles/profile_manager.cc. Thanks.
3 years, 7 months ago (2017-05-11 03:30:59 UTC) #68
Mr4D (OOO till 08-26)
profile_manager lgtm
3 years, 7 months ago (2017-05-11 03:58:38 UTC) #73
Finnur
chrome/browser/extensions/ OWNERS LGTM
3 years, 7 months ago (2017-05-11 11:17:18 UTC) #76
emaxx
On 2017/05/11 03:58:38, Mr4D (IO delays) wrote: > profile_manager lgtm On 2017/05/11 11:17:18, Finnur wrote: ...
3 years, 7 months ago (2017-05-11 18:01:05 UTC) #81
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801113002/180001
3 years, 7 months ago (2017-05-11 18:02:57 UTC) #84
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:11:41 UTC) #87
Message was sent while issue was closed.
Committed patchset #5 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/b4c388b2af93a40a40ebccd3a448...

Powered by Google App Engine
This is Rietveld 408576698