Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2801093002: Clear hash when setting URL in document.open (Closed)
Patch Set: Clear hash for document.open Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scrolling/doc-write-to-iframe.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 3b0b38b56fd88293a6901e60f057e37cfc54546a..f91aebe823d29a0a4b05cb69a6068ce20f49091d 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -2727,7 +2727,13 @@ void Document::open(Document* entered_document,
return;
}
SetSecurityOrigin(entered_document->GetSecurityOrigin());
- SetURL(entered_document->Url());
+
+ // Clear the hash fragment from the inerited URL to prevent a
skobes 2017/04/21 17:19:56 typo: inherited
bokan 2017/04/24 17:39:04 Done.
+ // scroll-into-view for any document.open()'d frame.
+ KURL new_url = entered_document->Url();
+ new_url.SetFragmentIdentifier(String());
+
+ SetURL(new_url);
skobes 2017/04/21 17:19:56 Does this code run only for cross-frame document.o
bokan 2017/04/24 17:39:04 Currently this was for any frame. I've changed it
cookie_url_ = entered_document->CookieURL();
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/scrolling/doc-write-to-iframe.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698