Clear hash when setting URL in document.open

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 2709 matching lines @@
   }
 
   if (entered_document) {
     if (!GetSecurityOrigin()->IsSameSchemeHostPortAndSuborigin(
             entered_document->GetSecurityOrigin())) {
       exception_state.ThrowSecurityError(
           "Can only call open() on same-origin documents.");
       return;
     }
     SetSecurityOrigin(entered_document->GetSecurityOrigin());
-    SetURL(entered_document->Url());
+
+    // Clear the hash fragment from the inerited URL to prevent a

[skobes, 2017/04/21 17:19:56]

typo: inherited

[bokan, 2017/04/24 17:39:04]

Done.

+    // scroll-into-view for any document.open()'d frame.
+    KURL new_url = entered_document->Url();
+    new_url.SetFragmentIdentifier(String());
+
+    SetURL(new_url);

[skobes, 2017/04/21 17:19:56]

Does this code run only for cross-frame document.open(), or also for
document.open() on the current frame?  We probably only want to do this in the
cross-frame case.

[bokan, 2017/04/24 17:39:04]

Currently this was for any frame. I've changed it to run only when opened from a
cross-frame document.

     cookie_url_ = entered_document->CookieURL();
   }
 
   open();
 }
 
 void Document::open() {
   DCHECK(!ImportLoader());
 
   if (frame_) {
@@ skipping 3911 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->Url().GetString().Utf8().Data());
 }
 #endif