Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2801073003: [local; kouhei 1][ES6 modules] Introduce ScriptModuleResolverImpl (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Introduce ScriptModuleResolverImpl This CL introduces ScriptModuleResolverImpl, which implements https://html.spec.whatwg.org/#hostresolveimportedmodule(referencingmodule,-specifier) This CL also introduces Modulator::getFetchedModuleScript() to synchronously get already fetched ModuleScript from the module map. BUG=594639 patch from issue 2790473002 at patchset 60001 (http://crrev.com/2790473002#ps60001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -0 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.h View 1 chunk +52 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp View 1 chunk +166 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (5 generated)
hiroshige
Description was changed from ========== [ES6 modules] Introduce ScriptModuleResolverImpl This CL introduces ScriptModuleResolverImpl, which implements ...
3 years, 8 months ago (2017-04-06 17:58:20 UTC) #1
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-06 17:58:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2801073003/1
3 years, 8 months ago (2017-04-06 17:59:41 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-06 19:08:10 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:08:10 UTC) #5
Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698