Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2799323002: [local; kouhei 2] kouhei's giant CL https://codereview.chromium.org/2555653002 (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -1 line) Patch
A third_party/WebKit/Source/core/dom/AncestorList.h View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.cpp View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/ModulatorImpl.h View 1 1 chunk +81 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/dom/ModulatorImpl.cpp View 1 1 chunk +156 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.h View 1 1 chunk +85 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp View 1 1 chunk +429 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerRegistry.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerRegistry.cpp View 1 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/testing/DummyModulator.cpp View 1 1 chunk +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2815453006 Patch 100001

Dependent Patchsets:

Issue 2817983002 Patch 1

Messages

Total messages: 17 (17 generated)
hiroshige
Description was changed from ========== local: https://codereview.chromium.org/2555653002 BUG= ========== to ========== local: https://codereview.chromium.org/2555653002 BUG= ==========
3 years, 8 months ago (2017-04-06 17:58:31 UTC) #1
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-06 17:58:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799323002/1
3 years, 8 months ago (2017-04-06 17:59:40 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-06 18:50:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/242685)
3 years, 8 months ago (2017-04-06 18:50:58 UTC) #5
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-12 18:44:31 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799323002/40001
3 years, 8 months ago (2017-04-12 18:45:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-12 19:31:31 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/247799)
3 years, 8 months ago (2017-04-12 19:31:32 UTC) #9
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-13 20:07:19 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799323002/60001
3 years, 8 months ago (2017-04-13 20:07:49 UTC) #11
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-13 20:09:59 UTC) #12
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-13 20:10:27 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799323002/60001
3 years, 8 months ago (2017-04-13 20:10:29 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/247631)
3 years, 8 months ago (2017-04-13 20:28:34 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-13 21:05:05 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 21:05:05 UTC) #17 
Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

Powered by Google App Engine
This is Rietveld 408576698